Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physics lite raycast bug (#999) #1104

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Fix physics lite raycast bug (#999) #1104

merged 2 commits into from
Oct 17, 2022

Conversation

yangfengzzz
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 42.77% // Head: 42.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4830331) compared to base (7eb64bc).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   42.77%   42.76%   -0.01%     
==========================================
  Files         337      337              
  Lines       17201    17200       -1     
  Branches     2397     2397              
==========================================
- Hits         7357     7356       -1     
+ Misses       9280     9279       -1     
- Partials      564      565       +1     
Impacted Files Coverage Δ
packages/core/src/physics/DynamicCollider.ts 15.29% <ø> (+0.35%) ⬆️
...ges/physics-lite/src/shape/LiteBoxColliderShape.ts 81.81% <75.00%> (+0.56%) ⬆️
packages/core/src/DisorderedArray.ts 55.55% <0.00%> (-7.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Oct 17, 2022
@GuoLei1990 GuoLei1990 changed the title fix: physics lite raycast bug (#999) Fix physics lite raycast bug (#999) Oct 17, 2022
@GuoLei1990 GuoLei1990 merged commit b391c74 into galacean:main Oct 17, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Oct 17, 2022
* commit 'b391c7441fc934139bf74d997424627b33ea9779':
  Fix physics lite raycast bug (galacean#999) (galacean#1104)
  fix: resource parser error (galacean#1105)
  v0.8.0-beta.31
  feat: add release action (galacean#1102)
  Fix `Compoment`/`Script` `onDisable` and  `onEnable` bug  (galacean#1087)
  Revert "fix: onDisable() call back scene is null bug (galacean#1098)" (galacean#1101)
  fix: onDisable() call back scene is null bug (galacean#1098)
  Add AnimatorController loader  for AniamtorController Editor (galacean#1078)
  v0.8.0-beta.30
  fix: pointer moving delta bug (galacean#1083)
  v0.8.0-beta.29
  fix: texture load bug in miniprogram (galacean#1077)
  v0.8.0-beta.28
  v0.8.0-beta.27
  Fix Material Resolved with Texture References (galacean#1076)
  Support glTF materials remap (galacean#1034)
  Fix wrong word recieveShadow to receiveShadow (galacean#1065)

# Conflicts:
#	lerna.json
#	packages/core/package.json
#	packages/core/src/shadow/Extension.ts
#	packages/core/src/shadow/ShadowFeature.ts
#	packages/design/package.json
#	packages/draco/package.json
#	packages/loader/package.json
#	packages/loader/src/index.ts
#	packages/loader/src/resource-deserialize/index.ts
#	packages/loader/src/resource-deserialize/resources/animatorController/type.ts
#	packages/math/package.json
#	packages/oasis-engine/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
#	tests/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants