Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findAnimatorState in Animator #1089

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Conversation

luzhuang
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@luzhuang luzhuang added this to the 0.9 milestone Oct 11, 2022
@luzhuang luzhuang requested a review from GuoLei1990 October 11, 2022 09:45
@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Oct 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 33.94% // Head: 42.11% // Increases project coverage by +8.17% 🎉

Coverage data is based on head (1728a32) compared to base (d978caa).
Patch coverage: 19.51% of modified lines in pull request are covered.

❗ Current head 1728a32 differs from pull request most recent head 787db60. Consider uploading reports for the commit 787db60 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/0.9    #1089      +/-   ##
===========================================
+ Coverage    33.94%   42.11%   +8.17%     
===========================================
  Files          333      341       +8     
  Lines        14824    17832    +3008     
  Branches      2275     2458     +183     
===========================================
+ Hits          5032     7510    +2478     
- Misses        9234     9720     +486     
- Partials       558      602      +44     
Impacted Files Coverage Δ
...ges/core/src/2d/assembler/SimpleSpriteAssembler.ts 28.20% <ø> (+3.88%) ⬆️
...ges/core/src/2d/assembler/SlicedSpriteAssembler.ts 5.47% <ø> (+2.66%) ⬆️
...s/core/src/animation/internal/AnimatorStateData.ts 50.00% <0.00%> (-50.00%) ⬇️
...ages/core/src/animation/internal/CrossCurveData.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/core/src/base/StaticInterfaceImplement.ts 100.00% <ø> (ø)
packages/core/src/lighting/LightManager.ts 34.24% <ø> (+12.93%) ⬆️
packages/loader/src/gltf/parser/AnimationParser.ts 2.56% <0.00%> (+1.69%) ⬆️
packages/loader/src/resource-deserialize/index.ts 0.00% <ø> (ø)
packages/oasis-engine/src/index.ts 100.00% <ø> (ø)
...ze/resources/animationClip/AnimationClipDecoder.ts 4.58% <2.89%> (ø)
... and 334 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 merged commit b2cf413 into galacean:dev/0.9 Oct 11, 2022
@GuoLei1990 GuoLei1990 changed the title feat: add get state API Add findAnimatorState in Animator Oct 11, 2022
@GuoLei1990 GuoLei1990 changed the title Add findAnimatorState in Animator Add findAnimatorState in Animator Oct 11, 2022
@GuoLei1990 GuoLei1990 added the animation Built-in animation system related functions label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants