Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnimatorController loader for AniamtorController Editor #1078

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

luzhuang
Copy link
Contributor

@luzhuang luzhuang commented Sep 26, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix: the issue: https://github.com/oasis-engine/editor/issues/937 https://github.com/oasis-engine/editor/issues/744 https://github.com/oasis-engine/editor/issues/985
The editor PR is : https://github.com/oasis-engine/editor/pull/958

@codecov-commenter
Copy link

Codecov Report

Base: 36.34% // Head: 42.57% // Increases project coverage by +6.23% 🎉

Coverage data is based on head (8db811d) compared to base (c3b2d6f).
Patch coverage: 34.91% of modified lines in pull request are covered.

❗ Current head 8db811d differs from pull request most recent head 31f1d30. Consider uploading reports for the commit 31f1d30 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   36.34%   42.57%   +6.23%     
==========================================
  Files         334      337       +3     
  Lines       14470    17201    +2731     
  Branches     2217     2399     +182     
==========================================
+ Hits         5259     7324    +2065     
- Misses       8635     9315     +680     
+ Partials      576      562      -14     
Impacted Files Coverage Δ
packages/core/src/animation/AnimatorController.ts 34.48% <0.00%> (+28.23%) ⬆️
packages/core/src/asset/AssetType.ts 100.00% <ø> (ø)
packages/core/src/input/pointer/PointerManager.ts 21.95% <0.00%> (+7.11%) ⬆️
packages/core/src/shader/ShaderProgram.ts 6.53% <0.00%> (+6.09%) ⬆️
packages/core/src/shadow/Extension.ts 18.75% <0.00%> (ø)
packages/core/src/shadow/ShadowFeature.ts 17.39% <0.00%> (+12.26%) ⬆️
packages/loader/src/MaterialLoader.ts 4.65% <0.00%> (+2.21%) ⬆️
packages/loader/src/gltf/GLTFUtil.ts 9.94% <0.00%> (+9.36%) ⬆️
packages/loader/src/gltf/parser/MaterialParser.ts 3.52% <0.00%> (+2.10%) ⬆️
packages/loader/src/gltf/parser/SceneParser.ts 5.88% <0.00%> (+4.74%) ⬆️
... and 328 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luzhuang luzhuang added the bug Something isn't working label Oct 11, 2022
@luzhuang luzhuang added this to the 0.9 milestone Oct 11, 2022
@luzhuang luzhuang changed the title Fix/animator controller feat: Add AnimatorController loader for AniamtorController Editor Oct 11, 2022
@GuoLei1990 GuoLei1990 added enhancement New feature or request and removed bug Something isn't working labels Oct 11, 2022
@GuoLei1990 GuoLei1990 changed the title feat: Add AnimatorController loader for AniamtorController Editor Add AnimatorController loader for AniamtorController Editor Oct 11, 2022
@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Oct 11, 2022
@GuoLei1990 GuoLei1990 merged commit a4baff3 into galacean:main Oct 11, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Oct 17, 2022
* commit 'b391c7441fc934139bf74d997424627b33ea9779':
  Fix physics lite raycast bug (galacean#999) (galacean#1104)
  fix: resource parser error (galacean#1105)
  v0.8.0-beta.31
  feat: add release action (galacean#1102)
  Fix `Compoment`/`Script` `onDisable` and  `onEnable` bug  (galacean#1087)
  Revert "fix: onDisable() call back scene is null bug (galacean#1098)" (galacean#1101)
  fix: onDisable() call back scene is null bug (galacean#1098)
  Add AnimatorController loader  for AniamtorController Editor (galacean#1078)
  v0.8.0-beta.30
  fix: pointer moving delta bug (galacean#1083)
  v0.8.0-beta.29
  fix: texture load bug in miniprogram (galacean#1077)
  v0.8.0-beta.28
  v0.8.0-beta.27
  Fix Material Resolved with Texture References (galacean#1076)
  Support glTF materials remap (galacean#1034)
  Fix wrong word recieveShadow to receiveShadow (galacean#1065)

# Conflicts:
#	lerna.json
#	packages/core/package.json
#	packages/core/src/shadow/Extension.ts
#	packages/core/src/shadow/ShadowFeature.ts
#	packages/design/package.json
#	packages/draco/package.json
#	packages/loader/package.json
#	packages/loader/src/index.ts
#	packages/loader/src/resource-deserialize/index.ts
#	packages/loader/src/resource-deserialize/resources/animatorController/type.ts
#	packages/math/package.json
#	packages/oasis-engine/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
#	tests/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ignore for release ignore for release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants