Fix scene root entity destroy bug #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 33.70% // Head: 33.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 33.70% 33.69% -0.01%
==========================================
Files 334 334
Lines 14458 14463 +5
Branches 2216 2217 +1
==========================================
+ Hits 4873 4874 +1
- Misses 9058 9060 +2
- Partials 527 529 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
czizzy
approved these changes
Sep 19, 2022
gz65555
approved these changes
Sep 19, 2022
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Sep 22, 2022
* main: v0.8.0-beta.26 feat: shader add properties get ability (galacean#1060) Fix scene root entity destroy bug (galacean#1062) Fix call `engine.destroy()` crash in `Script` (galacean#1059) Fix physics system stablity (galacean#1047) v0.8.0-beta.25 Fix script onDisable() error call bug (galacean#1055) fix: sprite transform error when rotates (galacean#1053) feat: remove throw (galacean#1052) Update README.md Update README.md v0.8.0-beta.24 Fix `TextRenderer` render error (galacean#1040) v0.8.0-beta.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: