Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should constrain shininess value like threejs did #748

Closed
susiwen8 opened this issue Apr 20, 2022 · 2 comments · Fixed by #749
Closed

Should constrain shininess value like threejs did #748

susiwen8 opened this issue Apr 20, 2022 · 2 comments · Fixed by #749
Assignees
@susiwen8
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@susiwen8
Copy link
Contributor

I just saw in threejs, shininess must not be 0 to prevent pow(0.0, 0.0).
I was wondering that should Oasis take the same action?
If this were necessary. I'm happy to create a PR for it.
@GuoLei1990
Copy link
Member

GuoLei1990 commented Apr 20, 2022 •
edited
Loading

I think you are right, pow(0.0, 0.0) maybe 1 in shader, this is not what we expected！
Welcome to contribute a PR！

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Apr 20, 2022
@GuoLei1990 GuoLei1990 added the good first issue Good for newcomers label Apr 20, 2022
@susiwen8 susiwen8 mentioned this issue Apr 21, 2022
Merged
3 tasks
@susiwen8
Copy link
Contributor Author

@GuoLei1990 PR is ready, please review it. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susiwen8 susiwen8

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: constrain min shininess to 1e-4
2 participants
@GuoLei1990 @susiwen8