Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color space correction #216

Closed
7 tasks done
zhuxudong opened this issue Apr 14, 2021 · 0 comments · Fixed by #543
Closed
7 tasks done

Color space correction #216

zhuxudong opened this issue Apr 14, 2021 · 0 comments · Fixed by #543
Assignees
@zhuxudong
Labels
enhancement New feature or request medium priority Medium priority issue Rendering Rendering related functions
Milestone
0.6

Comments

@zhuxudong
Copy link
Member

zhuxudong commented Apr 14, 2021 •
edited
Loading

RGBE -> linear

  • sh baker
  • IBL baker

linear -> RGBM

  • IBL baker -> export

gamma -> linear

  • baseTexture
  • emissiveTexture

RGBM -> linear

  • IBL in runtime

linear -> gamma

  • output in runtime
@zhuxudong zhuxudong added enhancement New feature or request Rendering Rendering related functions labels Apr 14, 2021
@zhuxudong zhuxudong added this to the 0.5 milestone Apr 14, 2021
@zhuxudong zhuxudong self-assigned this Apr 14, 2021
@zhuxudong zhuxudong modified the milestones: 0.5, Backlog Apr 14, 2021
@zhuxudong zhuxudong mentioned this issue May 31, 2021
Closed
3 tasks
@zhuxudong zhuxudong linked a pull request May 31, 2021 that will close this issue
perf: PBR Enhancement #314
Closed
3 tasks
@zhuxudong zhuxudong mentioned this issue Jun 15, 2021
Closed
3 tasks
@zhuxudong zhuxudong linked a pull request Jun 15, 2021 that will close this issue
perf: PBR Enhancement #334
Closed
3 tasks
@zhuxudong zhuxudong modified the milestones: Backlog, 0.5 Jun 21, 2021
@GuoLei1990 GuoLei1990 added the medium priority Medium priority issue label Jun 28, 2021
This was unlinked from pull requests Jul 16, 2021
perf: PBR Enhancement #314
Closed
perf: PBR Enhancement #334
Closed
@zhuxudong zhuxudong linked a pull request Jul 16, 2021 that will close this issue
perf: PBR Enhancement #334
Closed
3 tasks
@GuoLei1990 GuoLei1990 modified the milestones: 0.5, 0.6 Aug 13, 2021
zhuxudong pushed a commit to zhuxudong/engine that referenced this issue Sep 27, 2021
feat: gamma and linear color space correction galacean#216
b2d883c
@zhuxudong zhuxudong mentioned this issue Sep 28, 2021
Merged
3 tasks
@GuoLei1990 GuoLei1990 linked a pull request Oct 29, 2021 that will close this issue
Add color space #543
Merged
3 tasks
@GuoLei1990 GuoLei1990 moved this to Done in PBR material Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuxudong zhuxudong

Labels
enhancement New feature or request medium priority Medium priority issue Rendering Rendering related functions
Projects
PBR material
Status: Done
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Add color space GuoLei1990/galacean-engine
perf: PBR Enhancement zhuxudong/engine
2 participants
@GuoLei1990 @zhuxudong