fix: constrain min shininess to 1e-4 (#749)

* fix: constrain min shininess to `1e-4`
galacean · Apr 22, 2022 · e528ee3 · e528ee3
1 parent f077f1b
commit e528ee3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/core/src/material/BlinnPhongMaterial.ts b/packages/core/src/material/BlinnPhongMaterial.ts
@@ -145,7 +145,7 @@ export class BlinnPhongMaterial extends BaseMaterial {
   }
 
   set shininess(value: number) {
-    this.shaderData.setFloat(BlinnPhongMaterial._shininessProp, value);
+    this.shaderData.setFloat(BlinnPhongMaterial._shininessProp, Math.max(value, 1e-4));
   }
 
   /**

diff --git a/packages/core/tests/material/BlinnPhongMaterial.test.ts b/packages/core/tests/material/BlinnPhongMaterial.test.ts
@@ -49,11 +49,13 @@ describe("BlinnPhongMaterial", () => {
     material.specularTexture = null;
     material.emissiveTexture = null;
     material.normalTexture = null;
+    material.shininess = 0;
 
     expect(material.baseTexture).toBeNull();
     expect(material.specularTexture).toBeNull();
     expect(material.emissiveTexture).toBeNull();
     expect(material.normalTexture).toBeNull();
+    expect(material.shininess).toBe(1e-4);
   });
 
   it("clone", () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -145,7 +145,7 @@ export class BlinnPhongMaterial extends BaseMaterial { @@
       }
       set shininess(value: number) {
-        this.shaderData.setFloat(BlinnPhongMaterial._shininessProp, value);
+        this.shaderData.setFloat(BlinnPhongMaterial._shininessProp, Math.max(value, 1e-4));
       }
       /**
@@ Expand Down @@