This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): add support for compiling solc in parallel #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the svm feature is used, contracts are grouped by their required solidity version and compiled separately. Instead of processing this sequentially, we can spawn multiple processes concurrently using the
async_compile
functions which is faster.Solution
Solc::compile_many -> CompileMany
which effectively works like aFuturesUnordered
capped at a certain number, (num_cpus
in our case).job
parameter inProject
which sets this threshold, (default, num_cpu)svm_compile
we check if we can usecompile_many
and use that insteadI was able to unify some stuff and refactor some things, but there is probably still some code duplication in those to branches (jobs == 1 || jobs > 1) when it comes to artifact and cache handling.
needs some further testing with forge.
PR Checklist