Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(etherscan): transaction endpoints #512

Merged
merged 3 commits into from
Oct 17, 2021
Merged

feat(etherscan): transaction endpoints #512

merged 3 commits into from
Oct 17, 2021

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Oct 16, 2021 •
edited
Loading

Motivation

#485

Add etherscan.io transaction endpoints

Solution

Added them

PR Checklist

  • Add transaction endpoints
  • Move contract endpoints to separate contract.rs file
  • Add Chain enum to pass it into Client::new instead of plain strings

@shekhirin shekhirin force-pushed the feat/etherscan-transaction branch 2 times, most recently from 5f67710 to 852b2be Compare October 16, 2021 14:58
@shekhirin shekhirin force-pushed the feat/etherscan-transaction branch from 852b2be to cdb4c37 Compare October 16, 2021 16:02
@shekhirin shekhirin marked this pull request as ready for review October 16, 2021 16:13
gakonst
gakonst approved these changes Oct 17, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made some minor modifications on error handling.

@gakonst gakonst merged commit 071a416 into gakonst:master Oct 17, 2021
@gakonst gakonst mentioned this pull request Oct 17, 2021
Open
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @gakonst