This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
add uncle related missing api #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
suggested changes
Aug 19, 2021
ethers-providers/src/provider.rs
Outdated
| }) | ||
| } | ||
|
|
||
| async fn get_uncle_gen( |
There was a problem hiding this comment.
Suggested change
| async fn get_uncle_gen( | |
| async fn get_uncle( |
The _gen suffix was added to the get_block_gen function, so that you can choose between getting just the transaction hashes or the full transaction set due to the boolean parameter supplied to it. In this case it shouldn't be necessary since uncle blocks are always w/o transactions.
ethers-providers/src/provider.rs
Outdated
| @@ -164,6 +164,40 @@ impl<P: JsonRpcClient> Provider<P> { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| async fn get_uncle_count_gen(&self, id: BlockId) -> Result<U256, ProviderError> { | |||
There was a problem hiding this comment.
Suggested change
| async fn get_uncle_count_gen(&self, id: BlockId) -> Result<U256, ProviderError> { | |
| async fn get_uncle_count(&self, id: BlockId) -> Result<U256, ProviderError> { |
Same comment as below
ethers-providers/src/provider.rs
Outdated
| &self, | ||
| block_hash_or_number: T, | ||
| ) -> Result<U256, Self::Error> { | ||
| self.get_uncle_count_gen(block_hash_or_number.into()).await |
There was a problem hiding this comment.
Suggested change
| self.get_uncle_count_gen(block_hash_or_number.into()).await | |
| self.get_uncle_count(block_hash_or_number.into()).await |
ethers-providers/src/provider.rs
Outdated
| block_hash_or_number: T, | ||
| idx: U256, | ||
| ) -> Result<Option<Block<H256>>, ProviderError> { | ||
| self.get_uncle_gen(block_hash_or_number.into(), idx).await |
There was a problem hiding this comment.
Suggested change
| self.get_uncle_gen(block_hash_or_number.into(), idx).await | |
| self.get_uncle(block_hash_or_number.into(), idx).await |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
missing uncle block related api
Solution
add uncle block related missing api