This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: source code downloading and update api url on metis network #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Dec 1, 2023
| @@ -516,7 +516,7 @@ impl Chain { | |||
| } | |||
|
|
|||
| Metis => { | |||
| ("https://andromeda-explorer.metis.io/api", "https://andromeda-explorer.metis.io/") | |||
| ("https://api.routescan.io/v2/network/mainnet/evm/1088/etherscan/api", "https://explorer.metis.io/") | |||
There was a problem hiding this comment.
this url looks oddly long,
is this documented somewhere?
There was a problem hiding this comment.
|
do you have a sample response that fails deserialization? |
You can query this api to get the response |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when we run
cast etherscan-source --chain 1088 0x6c3bD2D5885D9e8a9B48c403EEb7A25195b7CCc1to download source code on metis network, it throws an errordata did not match any variant of untagged enum ResponseDatawhich is because the response from the apihttps://andromeda-explorer.metis.io/apiis not 100% compatible with the etherscan, so when it tries to deserialize it here during the sanity check the error is thrown.Solution
Metis has a new updated explorer and api which is more compatible with etherscan. The api response for downloading the source code on the new api is in-line with the etherscan one and should fix the issue.
Also as per the Metis team, the old api url and explorer is soon gonna be deprecated so I think it is a good idea to update it.
PR Checklist