Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

refactor(abigen): keep and use parsed spans #2247

Merged
merged 6 commits into from
Mar 13, 2023
Merged

refactor(abigen): keep and use parsed spans #2247

merged 6 commits into from
Mar 13, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Keep spans around instead of unparsing into Strings

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

mattsse
mattsse suggested changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great.

but I want to get rid of Abigen pub fields. don't think they need to be mutable or do they?

ethers-contract/ethers-contract-abigen/src/lib.rs Outdated Show resolved Hide resolved
ethers-contract/ethers-contract-derive/src/abigen.rs Outdated Show resolved Hide resolved
@DaniPopes
Copy link
Collaborator Author

They do for the builder, allows direct access to maps

@mattsse
Copy link
Collaborator

mattsse commented Mar 10, 2023

since this is a public type, I'd rather have immutable getter functions.

@DaniPopes
Copy link
Collaborator Author

Clippy unrelated, looks like a new lint dropped

@gakonst gakonst merged commit c9a7b4a into gakonst:master Mar 13, 2023
@DaniPopes DaniPopes deleted the refactor/abigen-parsing branch March 14, 2023 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattsse mattsse mattsse requested changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @mattsse @gakonst