Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

test: update test with changed state on forked tests #1353

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

meetmangukiya
Copy link
Contributor

@meetmangukiya meetmangukiya commented Jun 7, 2022

Fix tests

@meetmangukiya
Copy link
Contributor Author

meetmangukiya commented Jun 7, 2022

---- eth_tests::watch_events stdout ----
thread 'eth_tests::watch_events' panicked at 'assertion failed: `(left == right)`
  left: `"initial value"`,
 right: `"0"`', ethers-contract/tests/contract.rs:291:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I think there is some bug in anvil filters that are returning logs from blocks before the filter was created, ws stream seems to be working fine. /cc @mattsse

Context:
initial value log / event is emitted from the constructor, we are establishing the filter after deploying the contract, so the filter should not be notifying that event to the user.

@gakonst
Copy link
Owner

gakonst commented Jun 7, 2022

The logs issue is fixed in foundry-rs/foundry#1861

@gakonst gakonst merged commit 6bddd53 into gakonst:master Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants