Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL as peerDep #7

Closed
bkniffler opened this issue Jan 22, 2018 · 5 comments · May be fixed by LibreTubeApp/LibreTube#14
Closed

GraphQL as peerDep #7

bkniffler opened this issue Jan 22, 2018 · 5 comments · May be fixed by LibreTubeApp/LibreTube#14
Labels

Comments

@bkniffler
Copy link

Hey, I'm getting

Uncaught Error: Cannot use e "__Schema" from another module or realm.

Ensure that there is only one instance of "graphql" in the node_modules
directory. If different versions of "graphql" are the dependencies of other
relied on modules, use "resolutions" to ensure only one version is installed.

I suppose its due to the babel-plugin using 0.10.5 while my app uses >1.0.0. Could we get rid of the dependency in the plugin?

@gajus gajus added the question label Jan 22, 2018
@gajus
Copy link
Owner

gajus commented Jan 22, 2018

The appropriate thing to do here is to update the dependency.

I am not familiar though with what were the breaking changes.

@jaydenseric
Copy link

jaydenseric commented Jan 24, 2018

It should be a peer dep, along with graphql-tag probably.

@bkniffler
Copy link
Author

I think its safe to assume that people who implement this plugin would install graphql and graphql-tag themselves, just as you'd assume people will install react when you create and publish some react component. Thats why most react components will have react in their peerDependencies.

@gajus gajus closed this as completed in 023c03a Jan 24, 2018
@jaydenseric
Copy link

@gajus Awesome 🙌

Any chance we could bump the graphql peer dep up to version 0.11 - 0.12, or will that involve a bit of compatibility work?

@gajus
Copy link
Owner

gajus commented Jan 24, 2018

Any chance we could bump the graphql peer dep up to version 0.11 - 0.12, or will that involve a bit of compatibility work?

No clue. Didn't touch it as part of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants