Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable customization of backtrace start/end banners #1623

Closed
dandee opened this issue Jul 16, 2020 · 7 comments
Closed

Enable customization of backtrace start/end banners #1623

dandee opened this issue Jul 16, 2020 · 7 comments

Comments

@dandee
Copy link

dandee commented Jul 16, 2020

I'd like to set my own backtrace start/end banners or silence them completely. So instead of seeing this for example:

[2020-07-16 22:31:16.718] [info] ****************** Backtrace Start ******************
[2020-07-16 22:31:16.719] [info] Some log
[2020-07-16 22:31:16.721] [info] ****************** Backtrace End ********************
[2020-07-16 22:31:16.723] [info] App is doing well

I'd like to see this:

[2020-07-16 22:31:16.719] [info] Some log
[2020-07-16 22:31:16.723] [info] App is doing well

or this:

[2020-07-16 22:31:16.718] [info] Hello world!
[2020-07-16 22:31:16.719] [info] Some log
[2020-07-16 22:31:16.721] [info] and after the intermission now this:
[2020-07-16 22:31:16.723] [info] App is doing well
@Indra5196
Copy link

Is it okay to keep the banners in a text file? You can edit the file whenever you want to change the banners. Or are you looking for some other way?

@dandee
Copy link
Author

dandee commented Aug 25, 2020

The thing is that I've got a custom log sink that implements a custom GUI control. Due to its nature GUI controls are initialized much later that the application startup but I'd like to keep all logs presented in that GUI Log Control. Now: if there are backtraces present then the banners wouldn't bother me much (still, I'd like to customize them) BUT when there are no backtraces the banners are still present in the output making it a bit ugly (and possibly confusing for customers):

image

As for storing banners in a text file: I'd avoid that because that file would become an application resource, triggering all resource related issues (macOS bundle, embedded systems, etc.)

@gabime
Copy link
Owner

gabime commented Aug 25, 2020

Interesting to know that someone is actually using the backtrace feature. I am planning to remove it in v2.x due to lack of interest..

@Indra5196
Copy link

That should be fine but I just wanted to avoid recompilation everytime we change banners.

@gabime gabime closed this as completed Sep 7, 2020
@dandee
Copy link
Author

dandee commented Sep 7, 2020

Interesting to know that someone is actually using the backtrace feature. I am planning to remove it in v2.x due to lack of interest..

I think it'd be a step back in offered functionality. Not everything is a direct console application. You can have embedded system with sink configured to output through serial link which could mean that you'd lose traces emitted before client console connects to that link, etc.

@gabime
Copy link
Owner

gabime commented Sep 7, 2020

@dandee I think the ring buffer sink would be a good alternative to achieve this.

@dandee
Copy link
Author

dandee commented Sep 8, 2020

@dandee I think the ring buffer sink would be a good alternative to achieve this.

Fair enough! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants