Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create schema-level constraint for start/stop on SequenceLocation within Adjacencies #474

Closed
Mrinal-Thomas-Epic opened this issue Mar 5, 2024 · 3 comments · Fixed by #556
Assignees
Milestone

Comments

@Mrinal-Thomas-Epic
Copy link
Contributor

Currently, the SequenceLocation within an Adjacency is expected to have either start or stop populated, but not both. The constraint that both should not be populated is not specified anywhere in the schema, which could lead to confusion (e.g., discussion #471).

@ahwagner
Copy link
Member

ahwagner commented Mar 5, 2024

@Mrinal-Thomas-Epic this is great, thanks. Would you be interested in drafting the schema change?

@Mrinal-Thomas-Epic
Copy link
Contributor Author

Mrinal-Thomas-Epic commented Mar 25, 2024

I'll take a stab at draft the schema change. Before I write it out, do you or @d-cameron have any thoughts on whether it should just be implemented as just a constraint on the use of SequenceLocation within Adjacency, or whether we should make a different class for a point + direction on a sequence?

@ahwagner
Copy link
Member

@Mrinal-Thomas-Epic I think a constraint definition makes the most sense for forward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants