Skip to content

Commit b1f5144

Browse files
g12ng12n
committed
removed buggy image filter declaration
As pointed out by Dane Springmeyer ( springmeyer ) blur couldnt be reset by zoom-level. »image-filters actually operate at the style level (like the bar opacity parameter - see mapbox/carto#249) and are applied to the rendering canvas once all features are rendered. « Signed-off-by: mge <[email protected]>
1 parent a7d37bc commit b1f5144

File tree

4 files changed

+35
-88
lines changed

4 files changed

+35
-88
lines changed

‎CardboardMap.tm2/.thumb.png

765 Bytes
Loading

‎CardboardMap.tm2/project.xml

+26-77
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<Parameters>
66
<Parameter name="attribution"><![CDATA[Map data © OpenStreetMap contributors]]></Parameter>
77
<Parameter name="bounds">-180,-85.0511,180,85.0511</Parameter>
8-
<Parameter name="center">-4.5263671875,53.91081008725409,6</Parameter>
8+
<Parameter name="center">-4.866943359375,54.23955053156177,6</Parameter>
99
<Parameter name="description"><![CDATA[Tilemill 2 Map Style based on a Carboard look]]></Parameter>
1010
<Parameter name="format">png8:m=h</Parameter>
1111
<Parameter name="maxzoom">22</Parameter>
@@ -51,46 +51,46 @@
5151
</Rule>
5252
<Rule>
5353
<MaxScaleDenominator>12500</MaxScaleDenominator>
54-
<Filter>([type] = 'canal')</Filter>
54+
<Filter>([type] = 'river')</Filter>
5555
<LineSymbolizer stroke-width="3" stroke="#c3e6ff" />
5656
</Rule>
5757
<Rule>
5858
<MaxScaleDenominator>50000</MaxScaleDenominator>
5959
<MinScaleDenominator>12500</MinScaleDenominator>
60-
<Filter>([type] = 'canal')</Filter>
60+
<Filter>([type] = 'river')</Filter>
6161
<LineSymbolizer stroke-width="2" stroke="#c3e6ff" />
6262
</Rule>
6363
<Rule>
6464
<MaxScaleDenominator>200000</MaxScaleDenominator>
6565
<MinScaleDenominator>50000</MinScaleDenominator>
66-
<Filter>([type] = 'canal')</Filter>
66+
<Filter>([type] = 'river')</Filter>
6767
<LineSymbolizer stroke-width="1" stroke="#c3e6ff" />
6868
</Rule>
6969
<Rule>
7070
<MinScaleDenominator>200000</MinScaleDenominator>
71-
<Filter>([type] = 'canal')</Filter>
71+
<Filter>([type] = 'river')</Filter>
7272
<LineSymbolizer stroke="#c3e6ff" stroke-width="0.5" />
7373
</Rule>
7474
<Rule>
7575
<MaxScaleDenominator>12500</MaxScaleDenominator>
76-
<Filter>([type] = 'river')</Filter>
76+
<Filter>([type] = 'canal')</Filter>
7777
<LineSymbolizer stroke-width="3" stroke="#c3e6ff" />
7878
</Rule>
7979
<Rule>
8080
<MaxScaleDenominator>50000</MaxScaleDenominator>
8181
<MinScaleDenominator>12500</MinScaleDenominator>
82-
<Filter>([type] = 'river')</Filter>
82+
<Filter>([type] = 'canal')</Filter>
8383
<LineSymbolizer stroke-width="2" stroke="#c3e6ff" />
8484
</Rule>
8585
<Rule>
8686
<MaxScaleDenominator>200000</MaxScaleDenominator>
8787
<MinScaleDenominator>50000</MinScaleDenominator>
88-
<Filter>([type] = 'river')</Filter>
88+
<Filter>([type] = 'canal')</Filter>
8989
<LineSymbolizer stroke-width="1" stroke="#c3e6ff" />
9090
</Rule>
9191
<Rule>
9292
<MinScaleDenominator>200000</MinScaleDenominator>
93-
<Filter>([type] = 'river')</Filter>
93+
<Filter>([type] = 'canal')</Filter>
9494
<LineSymbolizer stroke="#c3e6ff" stroke-width="0.5" />
9595
</Rule>
9696
</Style>
@@ -137,19 +137,14 @@
137137
srs="+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0.0 +k=1.0 +units=m +nadgrids=@null +wktext +no_defs +over">
138138
</Layer>
139139

140-
<Style name="tunnel-inset" filter-mode="first" image-filters="agg-stack-blur(0,0),agg-stack-blur(1,1)">
140+
<Style name="tunnel-inset" filter-mode="first" image-filters="agg-stack-blur(1,1)">
141141
<Rule>
142142
<MinScaleDenominator>12500000</MinScaleDenominator>
143-
<LineSymbolizer stroke-width="0.4" stroke="#ffffff" offset="0" geometry-transform="translate(2, 1)" />
143+
<LineSymbolizer stroke-width="0" stroke="#ffffff" offset="0" simplify="1" smooth="1" geometry-transform="translate(2, 0)" />
144144
</Rule>
145145
<Rule>
146146
<MaxScaleDenominator>12500000</MaxScaleDenominator>
147-
<MinScaleDenominator>25000</MinScaleDenominator>
148-
<LineSymbolizer stroke-width="0.6" stroke="#ffffff" offset="0" geometry-transform="translate(2, 1)" />
149-
</Rule>
150-
<Rule>
151-
<MaxScaleDenominator>25000</MaxScaleDenominator>
152-
<LineSymbolizer stroke="#ffffff" stroke-width="1" offset="0" geometry-transform="translate(2, 1)" />
147+
<LineSymbolizer stroke="#ffffff" stroke-width="1" offset="0" simplify="1" smooth="1" geometry-transform="translate(2, 0)" />
153148
</Rule>
154149
</Style>
155150
<Style name="tunnel" filter-mode="first" comp-op="multiply" opacity="0.2">
@@ -203,14 +198,8 @@
203198
<LineSymbolizer stroke-width="2" stroke="#000000" simplify="1" smooth="1" />
204199
</Rule>
205200
<Rule>
206-
<MaxScaleDenominator>750000</MaxScaleDenominator>
207201
<MinScaleDenominator>200000</MinScaleDenominator>
208202
<Filter>([class] = 'main')</Filter>
209-
<LineSymbolizer stroke-width="1" stroke="#000000" simplify="1" smooth="1" />
210-
</Rule>
211-
<Rule>
212-
<MinScaleDenominator>750000</MinScaleDenominator>
213-
<Filter>([class] = 'main')</Filter>
214203
<LineSymbolizer stroke="#000000" stroke-width="1" simplify="1" smooth="1" />
215204
</Rule>
216205
<Rule>
@@ -231,14 +220,8 @@
231220
<LineSymbolizer stroke-width="2" stroke="#000000" simplify="1" smooth="1" />
232221
</Rule>
233222
<Rule>
234-
<MaxScaleDenominator>750000</MaxScaleDenominator>
235223
<MinScaleDenominator>200000</MinScaleDenominator>
236224
<Filter>([class] = 'motorway')</Filter>
237-
<LineSymbolizer stroke-width="1" stroke="#000000" simplify="1" smooth="1" />
238-
</Rule>
239-
<Rule>
240-
<MinScaleDenominator>750000</MinScaleDenominator>
241-
<Filter>([class] = 'motorway')</Filter>
242225
<LineSymbolizer stroke="#000000" stroke-width="1" simplify="1" smooth="1" />
243226
</Rule>
244227
<Rule>
@@ -250,19 +233,14 @@
250233
<StyleName>tunnel</StyleName>
251234
<StyleName>tunnel-inset</StyleName> </Layer>
252235

253-
<Style name="road-inset" filter-mode="first" image-filters="agg-stack-blur(0,0),agg-stack-blur(1,1)">
236+
<Style name="road-inset" filter-mode="first" image-filters="agg-stack-blur(1,1)">
254237
<Rule>
255238
<MinScaleDenominator>12500000</MinScaleDenominator>
256-
<LineSymbolizer stroke-width="0.4" stroke="#ffffff" offset="0" geometry-transform="translate(2, 1)" />
239+
<LineSymbolizer stroke-width="0" stroke="#ffffff" offset="0" simplify="1" smooth="1" geometry-transform="translate(2, 0)" />
257240
</Rule>
258241
<Rule>
259242
<MaxScaleDenominator>12500000</MaxScaleDenominator>
260-
<MinScaleDenominator>25000</MinScaleDenominator>
261-
<LineSymbolizer stroke-width="0.6" stroke="#ffffff" offset="0" geometry-transform="translate(2, 1)" />
262-
</Rule>
263-
<Rule>
264-
<MaxScaleDenominator>25000</MaxScaleDenominator>
265-
<LineSymbolizer stroke="#ffffff" stroke-width="1" offset="0" geometry-transform="translate(2, 1)" />
243+
<LineSymbolizer stroke="#ffffff" stroke-width="1" offset="0" simplify="1" smooth="1" geometry-transform="translate(2, 0)" />
266244
</Rule>
267245
</Style>
268246
<Style name="road" filter-mode="first" comp-op="multiply" opacity="0.2">
@@ -316,14 +294,8 @@
316294
<LineSymbolizer stroke-width="2" stroke="#000000" simplify="1" smooth="1" />
317295
</Rule>
318296
<Rule>
319-
<MaxScaleDenominator>750000</MaxScaleDenominator>
320297
<MinScaleDenominator>200000</MinScaleDenominator>
321298
<Filter>([class] = 'main')</Filter>
322-
<LineSymbolizer stroke-width="1" stroke="#000000" simplify="1" smooth="1" />
323-
</Rule>
324-
<Rule>
325-
<MinScaleDenominator>750000</MinScaleDenominator>
326-
<Filter>([class] = 'main')</Filter>
327299
<LineSymbolizer stroke="#000000" stroke-width="1" simplify="1" smooth="1" />
328300
</Rule>
329301
<Rule>
@@ -344,14 +316,8 @@
344316
<LineSymbolizer stroke-width="2" stroke="#000000" simplify="1" smooth="1" />
345317
</Rule>
346318
<Rule>
347-
<MaxScaleDenominator>750000</MaxScaleDenominator>
348319
<MinScaleDenominator>200000</MinScaleDenominator>
349320
<Filter>([class] = 'motorway')</Filter>
350-
<LineSymbolizer stroke-width="1" stroke="#000000" simplify="1" smooth="1" />
351-
</Rule>
352-
<Rule>
353-
<MinScaleDenominator>750000</MinScaleDenominator>
354-
<Filter>([class] = 'motorway')</Filter>
355321
<LineSymbolizer stroke="#000000" stroke-width="1" simplify="1" smooth="1" />
356322
</Rule>
357323
<Rule>
@@ -363,19 +329,14 @@
363329
<StyleName>road</StyleName>
364330
<StyleName>road-inset</StyleName> </Layer>
365331

366-
<Style name="bridge-inset" filter-mode="first" image-filters="agg-stack-blur(0,0),agg-stack-blur(1,1)">
332+
<Style name="bridge-inset" filter-mode="first" image-filters="agg-stack-blur(1,1)">
367333
<Rule>
368334
<MinScaleDenominator>12500000</MinScaleDenominator>
369-
<LineSymbolizer stroke-width="0.4" stroke="#ffffff" offset="0" geometry-transform="translate(2, 1)" />
335+
<LineSymbolizer stroke-width="0" stroke="#ffffff" offset="0" simplify="1" smooth="1" geometry-transform="translate(2, 0)" />
370336
</Rule>
371337
<Rule>
372338
<MaxScaleDenominator>12500000</MaxScaleDenominator>
373-
<MinScaleDenominator>25000</MinScaleDenominator>
374-
<LineSymbolizer stroke-width="0.6" stroke="#ffffff" offset="0" geometry-transform="translate(2, 1)" />
375-
</Rule>
376-
<Rule>
377-
<MaxScaleDenominator>25000</MaxScaleDenominator>
378-
<LineSymbolizer stroke="#ffffff" stroke-width="1" offset="0" geometry-transform="translate(2, 1)" />
339+
<LineSymbolizer stroke="#ffffff" stroke-width="1" offset="0" simplify="1" smooth="1" geometry-transform="translate(2, 0)" />
379340
</Rule>
380341
</Style>
381342
<Style name="bridge" filter-mode="first" comp-op="multiply" opacity="0.2">
@@ -413,58 +374,46 @@
413374
</Rule>
414375
<Rule>
415376
<MaxScaleDenominator>12500</MaxScaleDenominator>
416-
<Filter>([class] = 'motorway')</Filter>
377+
<Filter>([class] = 'main')</Filter>
417378
<LineSymbolizer stroke-width="5" stroke="#000000" simplify="1" smooth="1" />
418379
</Rule>
419380
<Rule>
420381
<MaxScaleDenominator>50000</MaxScaleDenominator>
421382
<MinScaleDenominator>12500</MinScaleDenominator>
422-
<Filter>([class] = 'motorway')</Filter>
383+
<Filter>([class] = 'main')</Filter>
423384
<LineSymbolizer stroke-width="3" stroke="#000000" simplify="1" smooth="1" />
424385
</Rule>
425386
<Rule>
426387
<MaxScaleDenominator>200000</MaxScaleDenominator>
427388
<MinScaleDenominator>50000</MinScaleDenominator>
428-
<Filter>([class] = 'motorway')</Filter>
389+
<Filter>([class] = 'main')</Filter>
429390
<LineSymbolizer stroke-width="2" stroke="#000000" simplify="1" smooth="1" />
430391
</Rule>
431392
<Rule>
432-
<MaxScaleDenominator>750000</MaxScaleDenominator>
433393
<MinScaleDenominator>200000</MinScaleDenominator>
434-
<Filter>([class] = 'motorway')</Filter>
435-
<LineSymbolizer stroke-width="1" stroke="#000000" simplify="1" smooth="1" />
436-
</Rule>
437-
<Rule>
438-
<MinScaleDenominator>750000</MinScaleDenominator>
439-
<Filter>([class] = 'motorway')</Filter>
394+
<Filter>([class] = 'main')</Filter>
440395
<LineSymbolizer stroke="#000000" stroke-width="1" simplify="1" smooth="1" />
441396
</Rule>
442397
<Rule>
443398
<MaxScaleDenominator>12500</MaxScaleDenominator>
444-
<Filter>([class] = 'main')</Filter>
399+
<Filter>([class] = 'motorway')</Filter>
445400
<LineSymbolizer stroke-width="5" stroke="#000000" simplify="1" smooth="1" />
446401
</Rule>
447402
<Rule>
448403
<MaxScaleDenominator>50000</MaxScaleDenominator>
449404
<MinScaleDenominator>12500</MinScaleDenominator>
450-
<Filter>([class] = 'main')</Filter>
405+
<Filter>([class] = 'motorway')</Filter>
451406
<LineSymbolizer stroke-width="3" stroke="#000000" simplify="1" smooth="1" />
452407
</Rule>
453408
<Rule>
454409
<MaxScaleDenominator>200000</MaxScaleDenominator>
455410
<MinScaleDenominator>50000</MinScaleDenominator>
456-
<Filter>([class] = 'main')</Filter>
411+
<Filter>([class] = 'motorway')</Filter>
457412
<LineSymbolizer stroke-width="2" stroke="#000000" simplify="1" smooth="1" />
458413
</Rule>
459414
<Rule>
460-
<MaxScaleDenominator>750000</MaxScaleDenominator>
461415
<MinScaleDenominator>200000</MinScaleDenominator>
462-
<Filter>([class] = 'main')</Filter>
463-
<LineSymbolizer stroke-width="1" stroke="#000000" simplify="1" smooth="1" />
464-
</Rule>
465-
<Rule>
466-
<MinScaleDenominator>750000</MinScaleDenominator>
467-
<Filter>([class] = 'main')</Filter>
416+
<Filter>([class] = 'motorway')</Filter>
468417
<LineSymbolizer stroke="#000000" stroke-width="1" simplify="1" smooth="1" />
469418
</Rule>
470419
<Rule>

‎CardboardMap.tm2/project.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ bounds:
88
- 180
99
- 85.0511
1010
center:
11-
- -4.5263671875
12-
- 53.91081008725409
11+
- -4.866943359375
12+
- 54.23955053156177
1313
- 6
1414
description: Tilemill 2 Map Style based on a Carboard look
1515
format: "png8:m=h"
1616
interactivity_layer: ''
1717
maxzoom: 22
1818
minzoom: 0
19-
mtime: 1375998649857
19+
mtime: 1376034295471
2020
name: Cardboard Map
2121
scale: 1
2222
source: "mapbox:///mapbox.mapbox-streets-v3"

‎CardboardMap.tm2/style.mss

+6-8
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ Map {
7878
line-smooth: 1;
7979
[class='motorway'],
8080
[class='main'] {
81-
[zoom>=10] {line-width:1}
8281
[zoom>=12] {line-width:2}
8382
[zoom>=14] {line-width:3}
8483
[zoom>=16] {line-width:5}
@@ -93,13 +92,12 @@ Map {
9392
line-color:#fff;
9493
line-width:1;
9594
line-offset:0;
96-
line-geometry-transform: "translate(2, 1)";
97-
image-filters: agg-stack-blur(1,1);
98-
[zoom<=14]{line-width:0.6}
99-
[zoom<=5]{
100-
line-width:0.4;
101-
image-filters: agg-stack-blur(0,0);
102-
}
95+
line-simplify:1;
96+
line-smooth: 1;
97+
line-geometry-transform: "translate(2, 0)";
98+
image-filters: agg-stack-blur(1,1);
99+
[zoom<=5] {line-width:0}
100+
103101
}
104102
}
105103
/* Buildings */

0 commit comments

Comments
 (0)