Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Preferred foreign language #137

Open
dslize opened this issue Sep 2, 2024 · 2 comments
Open

Feature request: Preferred foreign language #137

dslize opened this issue Sep 2, 2024 · 2 comments

Comments

@dslize
Copy link

dslize commented Sep 2, 2024

I think it would be a good feature to allow a user to set a preferred foreign language during configuration of the addon. The use case is as follows: Suppose a user wants to primarily watch content in a foreign language x, but fall back to english if content is not available with an audio track in x. Right now, the user would select x, english (and maybe multi) during configuration. However when selecting a stream, the user often has to scroll to watch his content in x, because for many movies, there are a lot of results with 3 or more languages (that don't include x) which rank higher for a given quality/resolution, since the file tends to be bigger due to having more audio tracks. At worst, it will not show results in language x at all when the parameter Max Results is chosen as a small number during configuration.

I propose, similar to torrentio, to add a field for the preferred foreign language during configuration (ignored if left empty). Other than that, I'd say resolution takes precedence over preferred foreign language, i.e. an english 2160p movie is listed before a 1080p preferred foreign language movie, but within the 2160p category, preferred foreign language movies are listed before non-foreign language ones regardless of e.g. file size.

This would make the addon even better for me. If you agree with this, I can probably help you out with a pull request. Cheers

@g0ldyy
Copy link
Owner

g0ldyy commented Sep 3, 2024

working on it

@Zaarrg
Copy link

Zaarrg commented Nov 26, 2024

@dslize

If u still need it u can try out my fork comet-uncached. Mainly for uncached support but also includes some more advanced sorting and language search and preference which seems like you are looking for.
There was also a similar issue to yours might intrest you aswell.

Would appreciate any help any feedback to find bugs faster an make the pr possible faster of that fork.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants