From 517ccd331e0963f3ca7c51978d6dadab0b0cd611 Mon Sep 17 00:00:00 2001 From: ruuushhh Date: Wed, 7 Feb 2024 15:24:29 +0530 Subject: [PATCH] Comment Post to Integration settings --- .../apis/advanced_settings/serializers.py | 3 +- .../python/fill-accounting-export-summary.py | 30 ++++++++++--------- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/apps/workspaces/apis/advanced_settings/serializers.py b/apps/workspaces/apis/advanced_settings/serializers.py index 0d2886fd..fbb7e800 100644 --- a/apps/workspaces/apis/advanced_settings/serializers.py +++ b/apps/workspaces/apis/advanced_settings/serializers.py @@ -172,7 +172,8 @@ def update(self, instance, validated): if instance.onboarding_state == 'ADVANCED_CONFIGURATION': instance.onboarding_state = 'COMPLETE' instance.save() - AdvancedConfigurationsTriggers.post_to_integration_settings(instance.id, True) + # Commenting this for now, will uncomment once we expose to UI + # AdvancedConfigurationsTriggers.post_to_integration_settings(instance.id, True) return instance diff --git a/scripts/python/fill-accounting-export-summary.py b/scripts/python/fill-accounting-export-summary.py index ade0f5be..e5858bfb 100644 --- a/scripts/python/fill-accounting-export-summary.py +++ b/scripts/python/fill-accounting-export-summary.py @@ -52,23 +52,25 @@ error_type = 'ACCOUNTING_INTEGRATION_ERROR' if task_log.sage_intacct_errors else 'MAPPING' url = '{}/workspaces/main/dashboard'.format(settings.INTACCT_INTEGRATION_APP_URL) else: - export_id = expense_group.response_logs['url_id'] - url = 'https://www-p02.intacct.com/ia/acct/ur.phtml?.r={export_id}'.format( - export_id=export_id - ) + if expense_group.response_logs and 'url_id' in expense_group.response_logs: + export_id = expense_group.response_logs['url_id'] + url = 'https://www-p02.intacct.com/ia/acct/ur.phtml?.r={export_id}'.format( + export_id=export_id + ) for expense in expense_group.expenses.filter(accounting_export_summary__state__isnull=True): - expense_to_be_updated.append( - Expense( - id=expense.id, - accounting_export_summary=get_updated_accounting_export_summary( - expense.expense_id, - state, - error_type, - url, - False + if url: + expense_to_be_updated.append( + Expense( + id=expense.id, + accounting_export_summary=get_updated_accounting_export_summary( + expense.expense_id, + state, + error_type, + url, + False + ) ) ) - ) print('Updating {} expenses in batches of 50'.format(len(expense_to_be_updated))) __bulk_update_expenses(expense_to_be_updated)