Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global variable object tainted #41

Closed
Laumesis opened this issue Sep 10, 2021 · 1 comment
Closed

Global variable object tainted #41

Laumesis opened this issue Sep 10, 2021 · 1 comment

Comments

@Laumesis
Copy link

Laumesis commented Sep 10, 2021 •
edited
Loading

object is not defined as local variable in this scope, so this taints global one.
Global variable object tainted by BasicChatMods - Interface\AddOns\BasicChatMods\fade.lua:131

BasicChatMods/fade.lua

Line 131 in 2865681

object = chatFrame.buttonFrame

BasicChatMods/fade.lua

Line 137 in 2865681

object = chatFrame.ScrollBar

BasicChatMods/fade.lua

Line 143 in 2865681

object = chatFrame.ScrollToBottomButton

Sorry, I'm too lazy to fork and to make PR :(
@funkydude
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funkydude @Laumesis