Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cookie plugin into theme for better GraphCDN support #23

Closed
drewbaker opened this issue Feb 22, 2022 · 4 comments
Closed

Integrate cookie plugin into theme for better GraphCDN support #23

drewbaker opened this issue Feb 22, 2022 · 4 comments

Comments

@drewbaker
Copy link
Member

This is a plugin we currently use: https://github.com/MikhailRoot/samesite-cookie-manager/archive/refs/heads/master.zip

When using SSR sites with GraphCDN, we need to set the domain for cookies to .example.com, which isn't possible with Flywheel as they hard code the define() for COOKIE_DOMAIN to be the "WordPress Address (URL)".

So, I'd like to bring that code into the /functions directory, and upgrade it to use a settings field for the cookie domain. We have to be careful that we don't make it easy to allow the cookies to be set on a domain like "flywheelsites.com".

@drewbaker drewbaker changed the title Integrate cookie plugin into theme Integrate cookie plugin into theme for better GraphCDN support Feb 22, 2022
@drewbaker
Copy link
Member Author

I've found a temp fix is to just find-replace COOKIE_DOMAIN in that plugin with the preferred domain works fine as a workaround.

@drewbaker
Copy link
Member Author

@rsm0128 is working on this

@rsm0128
Copy link
Contributor

rsm0128 commented Mar 31, 2022

@drewbaker I created PR #27 to arrange this.

@drewbaker
Copy link
Member Author

Closed with 5bba037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants