Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep-alive - half the expected rate #99

Closed
vassilvk opened this issue Apr 8, 2019 · 1 comment
Closed

Keep-alive - half the expected rate #99

vassilvk opened this issue Apr 8, 2019 · 1 comment

Comments

@vassilvk
Copy link

vassilvk commented Apr 8, 2019

When using the -keepalive-time option, grpcurl sends keepalive pings to the server at half the expected rate.

Steps to reproduce

  • Set up a gRPC service which listens, for example, on endpoint 1.2.3.4:123
  • Run grpcurl with a 60 seconds keepalive-time ping against an API which takes say 5 min to complete:
./grpcurl -keepalive-time 60 1.2.3.4:123 my.Service/ExtremelySlowAPI
  • Run tcpdump to monitor packets being sent from grpcurl to the service:
tcpdump -i eth0 dst 1.2.3.4

Expected

You should see keepalive ping packets sent on the wire every 60 seconds.

Observed

tcpdump reports 2 keepalive ping packets sent at once, every 120 seconds.

@jhump
Copy link
Contributor

jhump commented May 14, 2020

This should be fixed as of v1.5.0 (as part of updating grpc-go dependency in #136).

@jhump jhump closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants