Python 2 support

[gruebel]

Hi,

wIth the changes from #263 the compatibility with Python 2 was broken. The problematic code part

credstash/credstash.py

Line 73 in 2dec65f

if logger.hasHandlers():

could be easily fixed by removing that line completely, because there is no benefit in checking, if the logger has any handlers. If it doesn't have any the next line line would iterate over an empty list and therefore not remove any handler. I could create a simple PR, but I'm not sure, which Python versions credstash is officially supporting. If you don't support Python 2, then you could also remove all code related to it, like

credstash/credstash.py

Line 15 in 2dec65f

from __future__ import print_function

credstash/credstash.py

Lines 30 to 33 in 2dec65f

	try:
	from StringIO import StringIO
	except ImportError:
	from io import StringIO

[corrjo]

IMO python2 support should be removed. Not wise to try and support something that is already eol, and removing support will encourage those still using python 2 to move to 3.

[kenzliang]

@corrjo While true - it probably should be noted that this was a patch version release not a minor or major one.

[tehamacrane]

Credstash 1.16.2 is definitely broken. We've had to roll back to 1.16.1 on all of our images. Any word on when a fix will be in?

[eisjcormier]

Any update on when this will be fixed?

[mike-luminal]

Agreed that breaking Python 2 compatibility is inappropriate for a patch release. Will fix for next release.