Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to move vendor/ directory for Go 1.5 compatibility #338

Closed
bufdev opened this issue Jul 30, 2015 · 0 comments
Closed

Need to move vendor/ directory for Go 1.5 compatibility #338

bufdev opened this issue Jul 30, 2015 · 0 comments

Comments

@bufdev
Copy link
Contributor

bufdev commented Jul 30, 2015

See https://docs.google.com/document/d/1Bz5-UB7g2uPBdOx-rw5t9MxJwkfpx90cqG9AFL0JAYo/edit for details

The new semantics changes the meaning of (breaks) source trees containing directories already named “vendor”. Of the over 60,000 listed on godoc.org, there are fewer than 50 such examples. Putting the new semantics behind the environment variable avoids breaking those trees for now.

If they did the analysis right, we would be one of those 50. I can do this soon, it will be pretty easy. We can't use the new go vendoring experiment yet and should stick with the party tool as using the new vendoring experiment would break compatibility with 1.3 and 1.4, but I would propose external instead of vendor, thoughts?

This is minorly urgent as 1.5 is due in about two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant