make signaturehelp traverse characters safely #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting an empty filename led to incorrect range comparisons, so we need a SourceText that knows its tagged fileName
baronfel
force-pushed
the
fix-signature-help-out-of-bounds
branch
from
b402183 to
8a7783d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #891 (comment), @quantum-booty had a log line that suggested
textDocument/signatureHelpwasn't traversing positions safely. This turned out to be the case, so I've pushed helper functions for safe incrementing and decrementing of positions down into the SourceText extensions, then updated the implementation of SignatureHelp to use these.