Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPERIMENT: Use FSharp.Data.Adaptive #1007

Merged
merged 85 commits into from
Oct 9, 2022

Conversation

TheAngryByrd
Copy link
Member

WIP to handle loading of projects and type checking in an adaptive way

let! diags = doc |> Document.waitForLatestDiagnostics (TimeSpan.FromSeconds 5.0)
Expect.equal diags Array.empty "There should be a final publishDiagnostics without any diags"
})
testCaseAsync

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any need for a testCase for Task? If these suggestions aren't useful, feel free to disregard.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like testCaseTask ?

@baronfel baronfel merged commit 4dea78f into ionide:main Oct 9, 2022
@Krzysztof-Cieslak
Copy link
Member

CC: @dsyme - the PR I've mentioned last week ;-)

@SupinePandora43
Copy link

Does it fix problems in vscode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants