-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test case for fake interop and update FAKE package #566
Conversation
@matthid there might need to be some work on the FAKE side of things to react to the DependencyManager work. |
@baronfel can't we just add a dependency manager to Fake which ignores all strings starting with paket just to get to a stable state again? |
Also can you explain why FAKE itself is working and not emitting those compiler errors? Do we need to add some preview flags? |
That's a good question. Do you have the set of flags/options you use to compile scripts handy? I could compare to what we set in the CompilerServiceInterface |
@matthid yes that could work. There are no docs for this stuff yet so let me scrounge together some links to code. |
@baronfel When using verbose you should see all compile flags in the console: https://github.com/fsharp/FAKE/blob/bdce1746a27764a630c1008c32326cc82ce90334/src/app/Fake.Runtime/CompileRunner.fs#L140 |
Thank you! I'll try to compare this morning. |
For the latest alpha of FCS options for test script
Options that FSAC resolves: FSAC options for the same file
|
5534389
to
fefca99
Compare
Ok, we're all fixed here now, thanks to @matthid. This test now passes and we've got a path going forward to detect any more of these kinds of issues. |
So this means next ionide update will fix stuff, correct? |
yep! And more importantly, we shouldn't regress the FAKE support accidentally anymore. |
fefca99
to
e596009
Compare
So this is going to be a problem.
The new FCS interprets the
#r "paket: ...."
syntax according to the new spec, but it throws an error and fails when detecting a syntax that it doesn't recognize. Specifically we get the following errors:when checking the
build.fsx
file checked in as a test case in this MR.