update version-finding algorithm to probe packs dir as well as runtime dir #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Feb 18, 2020
| @@ -149,21 +149,21 @@ module Environment = | |||
|
|
|||
| /// because 3.x is the minimum SDK that we support for FSI, we want to float to the latest | |||
| /// 3.x sdk that the user has installed, to prevent hard-coding. | |||
| let latest3xSdkVersion sdkRoot = | |||
| let latest3xSdkVersion dotnetRoot = | |||
There was a problem hiding this comment.
renamed these parameters to reflect their true purpose. SDK root in the current lingo means dotnet-root/sdk, but what was passed in to these functions is the dotnet-root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two phases to finding the complete set of .net core refs for typechecking:
The previous logic would check for runtime versions only in the shared runtime implementation directory (
dotnet-root/shared/Microsoft.NETCore.App), but then it would use that discovered runtime version when probing across the reference-assembly and implementation directories. This would result in a mismatch when the reference-assembly directory existed, but the version found in the implementation directory had no match in the reference-assembly directory. As an example, think runtime version 3.1.1, which from a reference-assembly perspective is binary-compatible with the 3.1.0 reference assemblies.This situation happens when there's not an updated set of façades for the runtime when a new runtime version is shipped, which I would expect to be the case for patch versions like 3.1.1.