Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM Artifact scans incorrectly #2368

Open
nguyentvan7 opened this issue Aug 7, 2024 · 4 comments
Open

EM Artifact scans incorrectly #2368

nguyentvan7 opened this issue Aug 7, 2024 · 4 comments
Labels
bug Something isn't working good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR

Comments

@nguyentvan7
Copy link
Collaborator

image
image

@nguyentvan7 nguyentvan7 added the bug Something isn't working label Aug 7, 2024
@frzyc frzyc added the good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR label Sep 27, 2024
@legndery
Copy link
Contributor

OCR is not able to read the EM main stat value:

texts
(2) ['Sands of Eon\n', 'Elemental Mastery\n']

@frzyc
Copy link
Owner

frzyc commented Dec 16, 2024

You are right, I am not sure what we can do to make this more accurate. Perhaps instead of a b/w highpass, we apply a better filter in this section? I would imaging the semi-transparent text being harder to OCR
image

@legndery
Copy link
Contributor

I tried few standard preprocessing steps and it seems the normal gaussian blur -> dilation -> invert -> threshold is working. We can crop the stars out to be more accurate though, with the histogram we are already doing it.
image
Result:
image

Ref taken from https://replit.com/@yuispl2/GameToText#script.js this as-is worked, corresponding article: https://dev.to/mathewthe2/using-javascript-to-preprocess-images-for-ocr-1jc

Is there any regression test we can run with you know bunch of images?

@frzyc
Copy link
Owner

frzyc commented Dec 16, 2024

No regression tests (every time we bring it up seems to be more of a hassel than just taking new screenshots from in-game anyways)

Looks like good progress. the bandpass filter we been using was sort of hacked together over a weekend, and was never iterated on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR
Projects
None yet
Development

No branches or pull requests

3 participants