Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the api to support fetching soundsets, onlineGlobalElements and onlineElements #46

Closed
tposney opened this issue Aug 18, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@tposney
Copy link

tposney commented Aug 18, 2022

Is your feature request related to a problem? Please describe.
Was looking at using this module to enhance the sounds players can play in midi-qol. To do this effectively I'd need to be able to show a list of one shots that they can use. I'm not aware of anyway to do that at present. Extending the pulblished api would make this straight forward for me.

Describe the solution you'd like
Add the following in initSettings game.setGlobal

        soundSources: async() => {
           return api.onlineSoundsets()
        },
        onlineElements: async(id) => {
            return api.onlineElements(id)
        },
        onlineGlobalElements: async () => {
            return api.onlineGlobalElements();
        }

Describe alternatives you've considered
Other than reinventing the wheel I can't see a good alternative.

Additional context
I hacked my local copy of syrinControl and the suggested changes seem to give me what I would need.

Thanks for your consideration. And a really nice piece of work by the way.

@YenBenGrey
Copy link

Hi Frondeus,
It was me who poked TPosney (the genius behind midi qol). I think it would be great to integrate. Being able to add one shots to critical hits or critical fails. As usual I’m available for testing.

@frondeus frondeus added enhancement New feature or request good first issue Good for newcomers labels Aug 24, 2022
@frondeus frondeus added this to the 0.4.0 milestone Aug 24, 2022
@frondeus frondeus moved this to In Progress in Syrin Control Jan 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Syrin Control Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants