Skip to content

Commit cbf1c9a

Browse files
committed
Use shared node base image. node != javascript
Whoops! I was about to add javascript, but I see that I have a whole language container dedicated to node (which isn't a language at all). So cleaned all that up.
1 parent be385f4 commit cbf1c9a

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

300-node/Dockerfile

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
FROM 100hellos/000-base:local
2+
3+
RUN sudo \
4+
apk add --no-cache \
5+
nodejs npm
6+
7+
+1-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
# syntax=docker/dockerfile:1
22
# escape=\
3-
FROM 100hellos/000-base:local
4-
5-
RUN sudo \
6-
apk add --no-cache \
7-
nodejs
3+
FROM 100hellos/300-node:local
84

95
COPY --chown=human:human ./files /hello-world

node/Makefile javascript/Makefile

File renamed without changes.
File renamed without changes.

typescript/Dockerfile

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
# syntax=docker/dockerfile:1
22
# escape=\
3-
FROM 100hellos/000-base:local
3+
FROM 100hellos/300-node:local
44

5-
RUN sudo \
6-
apk add --no-cache \
7-
nodejs npm \
8-
&& sudo npm i -g typescript
5+
RUN sudo npm i -g typescript
96

107
COPY --chown=human:human ./files /hello-world

0 commit comments

Comments
 (0)