Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB might end up in an undefined state since there is no rollback on errors in the migration code #123

Open
freol35241 opened this issue Aug 9, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@freol35241
Copy link
Owner

A more general approach would likely be to wrap the entire set of upgrade changes to the db in a a BEGIN/COMMIT block, with a ROLLBACK in case of errors, so a robust way would be to autocommit=False for all sql, plus some code to handle the commit. Out of scope for this PR though.

That should (in theory) prevent the db from getting into an undefined state.

Originally posted by @antoonhuiskens in #112 (comment)

@freol35241 freol35241 added the enhancement New feature or request label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant