Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Snap package #38

Open
dex4er opened this issue Oct 16, 2024 · 9 comments
Open

Provide Snap package #38

dex4er opened this issue Oct 16, 2024 · 9 comments
Assignees
Labels
distribution Distribution of the binaries enhancement New feature or request

Comments

@dex4er
Copy link
Collaborator

dex4er commented Oct 16, 2024

We could add Ubuntu Snap packages and distribute them in https://snapcraft.io/

Our electron-builder unfortunately does not support base option so it builds by default for core18 base.

However we can build new Snap package based on existing DEB package (see https://www.electronjs.org/docs/latest/tutorial/snapcraft#using-an-existing-debian-package) then handling Snaps would be separate job in GHA.

We can build and publish separate packages for main repo and nightly.

@dex4er dex4er added the enhancement New feature or request label Oct 16, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 18, 2024

Snap must be built outside electron-builder as the used version uses deprecated base18. Also we need additional tweaking for the manifest. Our snapcraft.yaml is mostly created from the Snap package for VScode, including the electron-launch wrapper.

Because Lens uses $HOME/.kube and $HOME/.freelens we must to build it in classic mode: strict mode protects the content of the $HOME directory.

@dex4er dex4er added this to the 0.1.1 milestone Oct 18, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 18, 2024

It makes less sens to distribute Snap packages outside https://snapcraft.io/ (similarly to Flatpaks outside https://flathub.org/). In that case, I'm going to remove Snaps from our releases as we need only DEB package.

@dex4er dex4er removed this from the 0.1.1 milestone Oct 18, 2024
@dex4er dex4er added the distribution Distribution of the binaries label Oct 25, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Jan 8, 2025

https://github.com/freelensapp/freelens-snap is created. We need ubuntu one account to register the package and ask for extra privileges in sandbox (~/.kube and ~/.freelens directories).

@dex4er
Copy link
Collaborator Author

dex4er commented Jan 21, 2025

@robertobandini robertobandini moved this from Todo to In Progress in freelens Jan 25, 2025
@dex4er
Copy link
Collaborator Author

dex4er commented Feb 9, 2025

Snap package is missing in action. Nobody knows how to re-register "freelens" name. Nobody can help us.

Anyway, it'll be a big problem to register "classic" Snap package and I'm afraid the "strict" confinement package would be just useless for users, without access to the applications from host (custom authentication in .kube/config).

@dex4er
Copy link
Collaborator Author

dex4er commented Feb 10, 2025

So now we have registered package named freelens-previous-name-was-revoked. I hope it is temporarily 😆

@elephantum
Copy link

Anyway, it'll be a big problem to register "classic" Snap package and I'm afraid the "strict" confinement package would be just useless for users, without access to the applications from host (custom authentication in .kube/config).

As a heavy Lens user, I never use standard .kube/config, I have several folders of configs, one config per cluster and I setup sync of these configs.

So, for me specifically it won't be an issue

@dex4er
Copy link
Collaborator Author

dex4er commented Feb 12, 2025

@elephantum It is more about using extra authentication agents than ~/.kube/config which can be used in strict mode too. We just can't include any existing Cloud SDK to the Snap package. Flatpak can call commands from the host OS via tunnel, Snap doesn't provide such option.

I asked for classic confinement: https://forum.snapcraft.io/t/request-classic-confinement-for-freelens-previous-name-was-revoked/45663

@elephantum
Copy link

@dex4er thanks for clarification! Indeed, that's much bigger issue and we really need authentication agents to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution Distribution of the binaries enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

3 participants