Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run diffoscope on new packages #6756

Open
legoktm opened this issue Feb 22, 2023 · 0 comments
Open

Automatically run diffoscope on new packages #6756

legoktm opened this issue Feb 22, 2023 · 0 comments

Comments

@legoktm
Copy link
Member

legoktm commented Feb 22, 2023

Description

To help developers gain confidence in what is changing, we should automatically run diffoscope on new packages.

How will this impact SecureDrop developers?

Historically our package build tooling has had a lot of moving parts and been quite...fragile. This led developers to not have a lot of confidence in the resulting package, so post-build tests to verify files were included and config was applied correctly were written, plus a pretty intensive manual QA process.

diffoscope enables us to diff different package versions and see exactly what changed, which should give us more confidence that things we didn't want to change stayed the same!

There are some options here, we could run diffoscope on each commit/PR, we could run it on package updates to the securedrop-apt-test/prod repos, maybe both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant