Upgrade scenario is broken

[conorsch]

Description

The upgrade scenario, used for testing in-place upgrades on Xenial, is no longer behaving well. First reported in #5870 (comment)

Steps to Reproduce

1. Check out latest develop branch
2. Run echo 1.7.1 > molecule/shared/stable.ver to use an existing box (1.8.0 boxes are unmerged, in Upgrade boxes for 1.8.0 (Xenial) #5870)
3. Run make upgrade-start

Expected Behavior

Scenario prep is completed, process exits 0, three (3) VMs are configured and ready for upgrade: app, mon, & apt.

Actual Behavior

Scenario prep hangs while creating the app server. If you run virt-manager, you can see that upgrade_apt was created fine (directly from the upstream Bento box), box

Comments

Suggestions to fix, any other relevant information.

[conorsch]

See test reports in #5870 (comment). I'm able to run through the process on develop and the machines create successfully for me. I do see a syntax problem related to Ansible logic, which should be addressed in the latest changes in #5870.

@rmol please try the test plan above and document your results here.

[rmol]

I checked out develop, modified stable.ver, built debs, and tried make upgrade-start. This was on Debian 10, Vagrant 2.2.14, libvirt.

The process has failed for me repeatedly, but not in the ways reported in #5870. There's no server hang, and it doesn't appear that the video driver is the problem.

[conorsch]

See #5870 (comment) In a nutshell, let's prioritize #5512 rather than continue trying to support the xenial upgrade logic.