Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual distro support broke "securedrop-admin verify" #5659

Closed
rmol opened this issue Nov 30, 2020 · 1 comment · Fixed by #5674
Closed

Dual distro support broke "securedrop-admin verify" #5659

rmol opened this issue Nov 30, 2020 · 1 comment · Fixed by #5674
Assignees
Labels
Milestone

Comments

@rmol
Copy link
Contributor

rmol commented Nov 30, 2020

Description

When adding support for Focal to the configuration tests in #5529, a check of the MOLECULE_SCENARIO_NAME environment variable broke securedrop-admin verify, where it's not set.

Steps to Reproduce

On an admin workstation:

  • Run securedrop-admin setup -t
  • Run securedrop-admin verify

Expected Behavior

That the configuration tests would run.

Actual Behavior

You get an error here saying 'NoneType' object has no attribute 'endswith'.

Comments

Should probably check if it's None or just add "" as the default in the os.environ.get call.

@eloquence eloquence added the bug label Dec 1, 2020
@zenmonkeykstop zenmonkeykstop self-assigned this Dec 1, 2020
@eloquence
Copy link
Member

(Added to 1.7.0 milestone, seems like we want a fix in place before QA begins.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants