Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ServerSpec tests to TestInfra #1580

Closed
conorsch opened this issue Feb 14, 2017 · 2 comments · Fixed by #1616
Closed

Convert ServerSpec tests to TestInfra #1580

conorsch opened this issue Feb 14, 2017 · 2 comments · Fixed by #1616
Assignees
Milestone

Comments

@conorsch
Copy link
Contributor

Substantial work has been done on config tests, currently implemented in ServerSpec (#1006). The config tests are not currently run automatically via a CI pipeline (#1067), but should be. Given recent efforts to improve the application tests (#1445, #1457, #1466, #1474, #1516), we should make a similar push to test the system hardening specifications.

The core developers already have strong familiarity with Python and pytest, so we should convert the existing config tests to TestInfra, which is pytest-based. Doing so would allow us to remove Ruby-based tooling from the repo and focus on a Python-only development environment for the foreseeable future.

The config tests must be updated before we make a concerted effort to improve the Ansible versioning situation on Admin Workstations (#1146, #1531). We'll also need a strong config testing baseline in order to evaluate the upgrade from Ubuntu Trusty to Xenial (#1530).

@conorsch
Copy link
Contributor Author

conorsch commented Mar 2, 2017

We should also test for supported versions of Ansible, and platform information, which will come in handy as we evaluate the Xenial transition.

In the context of #749, we can run a test to confirm that playbooks fail with known-bad vars (e.g. "amnesia" as username).

@conorsch
Copy link
Contributor Author

conorsch commented Mar 9, 2017

Test conversion largely complete in branch convert-serverspec-tests-to-testinfra. Have some clean up left to do, then will nail down some updates to the developer documentation, and we're good for a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants