Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses distro-specific version strings for all SecureDrop packages #87

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Feb 2, 2021

Status

Ready for review

Description of changes

Rebuilds all packages with distro-specific version strings, as presented in freedomofpress/securedrop#5765. Closes #85.

Conor Schaefer added 3 commits February 2, 2021 08:42
The securedrop-app-code deb build process emits a .tar.gz file that's
easy to add here accidentally. We only want .deb files in this repo, so
let's explicitly ignore the tarballs to reduce mistaken adds.
Cleans out the core/{xenial,focal} directories, removing unused older
versions. This cleanup is long overdue, but also required in order to
fix the dual-channel support, as described in [0].

[0] #85
removes focal pkgs
Rebuilt all packages via [0] and added them to the respective distro dir
for core/{xenial,focal}. Unused historical versions have already been
pruned.

[0] freedomofpress/securedrop#5765
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There are still the two unqualified ossec packages under core/xenial, but that might actually be a good test, as per your comment the versions should sort correctly.

@rmol rmol merged commit 0b33c18 into main Feb 2, 2021
@rmol rmol deleted the include-distro-in-version-strings branch February 2, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focal channel in apt-test isn't serving all packages
2 participants