ci: increment version and build nightly securedrop-client deb package #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkll
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Thanks @redshiftzero changes look great to me.
Reviewed CI output reproduced steps manually locally and inspected artifacts and version strings make sense.
| run: | ||
| name: Get latest tag for the project and make a source tarball | ||
| name: Create nightly version | ||
| command: | | ||
| cd ~/packaging/securedrop-* |
There was a problem hiding this comment.
This line could be problematic if we will use in the same container for multiple builds, but since we are doing 1 container per deb, this will work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes freedomofpress/securedrop-client#407 (see rationale for versioning scheme here)
Contains securedrop-client side changes for #50
Test build here: observe the built package is in
/home/circleci/debbuild/packaging/securedrop-client_0.0.8-dev-20190618-205506_all.debThis PR also contains some DRYing up so that the securedrop-proxy version of this change will be pretty minimal (to do once freedomofpress/securedrop-proxy#37 is merged)