Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide explicit handing of application/x-desktop in mimeapps.list #961

Closed
emkll opened this issue Mar 19, 2020 · 1 comment · Fixed by freedomofpress/securedrop-workstation#501

Comments

@emkll
Copy link
Contributor

emkll commented Mar 19, 2020

In freedomofpress/securedrop-workstation#494 (comment) , application/x-desktop files are opened in a dvm , without an explicit rule. In default VMs, they are opened in a text editor, likely because debian on qubes doesn't use all of gnome's tooling and gdm. However, to ensure defense-in-depth, we should explicitly add the association in the mimeapps.list

@conorsch
Copy link
Contributor

To aid in review, recall that file and xdg-mime may report different results:

$ file --mime-type /usr/share/applications/debian-xterm.desktop
/usr/share/applications/debian-xterm.desktop: text/plain
$ xdg-mime query filetype /usr/share/applications/debian-xterm.desktop
application/x-desktop

It's the latter we're trying to ensure is handled sufficient by the Client and associated tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants