downloading animation never ends if the file cannot be decrypted

[sssoleileraaa]

STR

1. Click on "Download" next to a file that you know will fail to decrypt with gpg --decrypt filepath because of a bad key, missing encrypted file in the expected filepath, etc. For repro purposes I suggest raising CryptoError during the decryption step of a file.

Expected

"Failed to download" message and the "Download" button to replace "Downloading" animation

Actual

"Failed to download" message and the "Downloading" animation continues indefinitely:

[redshiftzero]

@rmol started working on this today

[sssoleileraaa]

A recent change that was merged to master made it so that the downloading animation never ends, even if the file is successfully downloaded and decrypted.

[sssoleileraaa]

Actually I decided to make a issue, because it looks like the issue started when we mismatched the slot and signal signatures, which the open PR fixes.

[rmol]

The animation problem was because we used to use a timer to start the animation, and if the download process finished before the animation started, regardless of success or failure, the stop request happened early so the animation kept going.

This was fixed in #768.

[sssoleileraaa]

this was reintroduced at some point

[sssoleileraaa]

nvm i saw this when raising crypto error during the download step, which should never happen. i see this fixed with the following diff:

--- a/securedrop_client/api_jobs/downloads.py
+++ b/securedrop_client/api_jobs/downloads.py
@@ -172,6 +172,7 @@ class DownloadJob(ApiJob):
         Decrypt the file located at the given filepath and mark it as decrypted.
         '''
         try:
+            raise CryptoError('test')
             original_filename = self.call_decrypt(filepath, session)
             mark_as_decrypted(
                 type(db_object), db_object.uuid, session, original_filename=original_filename
(END)