Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client styling] Refactor client grid layout #259

Closed
ninavizz opened this issue Mar 7, 2019 · 3 comments
Closed

[client styling] Refactor client grid layout #259

ninavizz opened this issue Mar 7, 2019 · 3 comments
Assignees
Labels

Comments

@ninavizz
Copy link
Member

ninavizz commented Mar 7, 2019

Epic: UX Parity between prototypes & coded client (#261)

This Story: Re-Factor Client Grid
Refactor layout of client according to "Functional Regions" as mapped-out in the screens at the below Zeplin link.

Reference materials: https://zpl.io/V4OMBzy


Details, This Story:

  • Nina/Allie discussed in person, so hopefully much of that carries over to this
  • Functional regions in "Alpha" screen reflects current state of Client build
  • Functional regions in "Beta" screen reflects how it all should be re-jiggered to meet current UX vision
  • Branding art for Beta & final icon for "Inbox" TBD (blocked by SD-UX 36)
  • Ignore things in the Branding pane (such as Trash, Unreviewed, All Starred and and the Filter By Codename bar) that appear in screens and have no functional parity to what's already been built in Alpha. Those bits have yet to become formalized as features in Issues. 😈
  • See provided screens (at Zeplin link, above) for horizontal scaling of columns as window size is horizontally reduced
    • First reduce the width of the Messages/Reply column, while retaining the size of the Branding and Sources List columns
    • After the Messages/Reply column reaches its minimum-allowable width, begin to reduce the width of the Sources List column
    • With the 2 right columns reduced to their minimum widths, the window should not be able to scale-down further.
    • Branding column should not scale
  • Click on screens in Zeplin to see hex values, font styles, and padding specs. 😸
@eloquence
Copy link
Member

For clarity, per our discussion, to consider this issue resolved, iconography does not need to be done yet; if it helps to get the sizing right or avoid weird text cut-offs, that's fine, but otherwise this can be done in subsequent PRs.

@eloquence eloquence changed the title Re-Factor Client Grid w/in Update Client Styles to Beta [client styling] Refactor client grid layout Mar 7, 2019
@sssoleileraaa sssoleileraaa self-assigned this Mar 8, 2019
@ninavizz
Copy link
Member Author

IOU a gradient for the background on the Messaging and Source List columns! Grateful to @eloquence's spreadsheet for reminding me of that! 😸

@eloquence
Copy link
Member

This was moved to "Done" but not closed. Judging by the original issue description, which is chiefly focused on the layout, we can reasonably consider this first iteration done and handle additional changes in more tightly scoped follow-up issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants