From 61eb93a56c1d13a9fc5fbe80d449146a0cd3c1ec Mon Sep 17 00:00:00 2001 From: Allie Crevier Date: Mon, 9 Dec 2019 11:42:29 -0800 Subject: [PATCH] caller logs and handles exception --- securedrop_client/storage.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/securedrop_client/storage.py b/securedrop_client/storage.py index 494871c767..b44db95927 100644 --- a/securedrop_client/storage.py +++ b/securedrop_client/storage.py @@ -77,15 +77,10 @@ def get_remote_data(api: API) -> Tuple[List[SDKSource], List[SDKSubmission], Lis (remote_sources, remote_submissions, remote_replies) """ remote_submissions = [] # type: List[SDKSubmission] - try: - remote_sources = api.get_sources() - for source in remote_sources: - remote_submissions.extend(api.get_submissions(source)) - remote_replies = api.get_all_replies() - except Exception as ex: - # Log any errors but allow the caller to handle the exception. - logger.error(ex) - raise(ex) + remote_sources = api.get_sources() + for source in remote_sources: + remote_submissions.extend(api.get_submissions(source)) + remote_replies = api.get_all_replies() logger.info('Fetched {} remote sources.'.format(len(remote_sources))) logger.info('Fetched {} remote submissions.'.format(