Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should sign up email be moved to user.save callback? #292

Closed
ghost opened this issue Mar 31, 2015 · 2 comments
Closed

Should sign up email be moved to user.save callback? #292

ghost opened this issue Mar 31, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 31, 2015

https://github.com/FreeCodeCamp/freecodecamp/blob/master/controllers/user.js#L161-L183

If an error occurred on the user.save would it still send them an email welcoming them to the site?

Still learning so I'm not totally sure.
@QuincyLarson
Copy link
Contributor

Let me verify this real quick (since I have a Mandrill key)

@QuincyLarson
Copy link
Contributor

I've done this and it seems to work.

@ghost ghost closed this as completed Mar 31, 2015
@snyk-bot snyk-bot mentioned this issue Jul 21, 2021
Open
This was referenced Nov 9, 2021
Open
Open
@fcsouza fcsouza mentioned this issue Jun 22, 2022
Open
@snyk-bot snyk-bot mentioned this issue Mar 11, 2023
Open
@simha95 simha95 mentioned this issue Nov 30, 2023
Open
@schafeld schafeld mentioned this issue Nov 30, 2023
Open
@Dotty280983 Dotty280983 mentioned this issue Dec 5, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuincyLarson