Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

CSS grid auto-fill challenge passes when it shouldn't #215

Open
joshalling opened this issue Aug 3, 2018 · 2 comments
Open

CSS grid auto-fill challenge passes when it shouldn't #215

joshalling opened this issue Aug 3, 2018 · 2 comments

Comments

@joshalling
Copy link
Member

joshalling commented Aug 3, 2018

The CSS grid auto-fit challenge test passes when you apply auto-fit to the container class even though it specifies that you need to add it to the container2 class.

Steps to reproduce:

  • go to this challenge
  • change auto-fill on line 14 to auto-fit
  • click run the tests and it passes

This should be fairly easy for a beginner to take.

@Nirajn2311
Copy link
Member

@joshalling your link is broken due to a extra dot at the end.

@wudifeixue
Copy link
Contributor

I have just encountered the same problem too.

Basically, if you changed auto-fill to auto-fit it will also pass the challenge when you are supposed to change grid-template-columns: repeat(3, minmax(60px, 1fr)); to grid-template-columns: repeat(auto-fit, minmax(60px, 1fr)); for .container2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants