Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/warn on wrong runic version #1

Closed
KnutAM opened this issue Feb 27, 2025 · 3 comments
Closed

Error/warn on wrong runic version #1

KnutAM opened this issue Feb 27, 2025 · 3 comments

Comments

@KnutAM
Copy link

KnutAM commented Feb 27, 2025

I just hit a problem when my local Runic (v1.0) did one correction that was reverted by the repo CI's Runic (v1.1). That would be nice to make sure don't happen IMO.

Specific PR: Ferrite-FEM/Ferrite.jl#1161

Two ideas for solution

  1. Would it be an idea to allow specifying the Runic version in the yaml of the pre-commit, and then either (configurable?) error or warn if the one in @runic doesn't match?

  2. Allow the pre-commit to use a project-local environment with a checked in manifest in a subdirectory instead of the shared environment?

@fredrikekre
Copy link
Owner

The latest version of pre-commit support Julia as a language (pre-commit/pre-commit#3348). With that pre-commit will use it's own package environment and install Runic automatically so no need to involve @runic at all.

@KnutAM KnutAM closed this as completed Feb 27, 2025
@fredrikekre
Copy link
Owner

Still need to convert this repo to use that so reopening.

@fredrikekre fredrikekre reopened this Feb 27, 2025
@fredrikekre
Copy link
Owner

#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants