fix(minor): move Create Workspace button to footer #27221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogk
reviewed
Jul 30, 2024
Comment on lines
+98
to
+111
| <button data-label="New" class="btn btn-default ellipsis btn-new-workspace"> | ||
| <svg class="es-icon es-line icon-xs" style="" aria-hidden="true"> | ||
| <use class="" href="#es-line-add"></use> | ||
| </svg> | ||
| <span class="hidden-xs" data-label="Edit">New</span> | ||
| </button> | ||
| <button class="btn btn-default btn-sm mr-2 btn-edit-workspace" data-label="Edit"> | ||
| <svg class="es-icon es-line icon-xs" style="" aria-hidden="true"> | ||
| <use class="" href="#es-line-edit"></use> | ||
| </svg> | ||
| <span class="hidden-xs" data-label="Edit"> | ||
| <span><span class="alt-underline">E</span>dit</span> | ||
| </span> | ||
| </button> |
There was a problem hiding this comment.
Shouldn't the button labels be translated?
akhilnarang
added a commit
that referenced
this pull request
Jul 30, 2024
…-27221 fix(minor): move Create Workspace button to footer (backport #27221)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
# [15.37.0](v15.36.1...v15.37.0) (2024-08-07) ### Bug Fixes * add translation function to route label text ([#27175](#27175)) ([2012309](2012309)) * **auto_email_report:** ensure that a report is selected before we try to apply filters ([f9173e5](f9173e5)) * **babel:** not a valid locale identifier (backport [#26749](#26749)) ([#27217](#27217)) ([5bf7625](5bf7625)) * default notification (backport [#27294](#27294)) ([#27295](#27295)) ([330bb47](330bb47)) * disable fuzzy matching while updating po files (backport [#27257](#27257)) ([#27258](#27258)) ([23b4baf](23b4baf)) * Email Sent Twice ([#27227](#27227)) ([f7af067](f7af067)) * extract translatable strings from .vue files (backport [#27251](#27251)) ([#27252](#27252)) ([6e40f96](6e40f96)) * fetch from not working in quick entry form ([ce710ed](ce710ed)) * fetch from select twice ([90ae4e4](90ae4e4)) * header block is not translatable ([bf82036](bf82036)) * layout of checkboxes in print sidebar ([de0a762](de0a762)) * make workspace buttons translatable ([a09bc3d](a09bc3d)), closes [/github.com//pull/27221/files#r1696441166](https://github.com//github.com/frappe/frappe/pull/27221/files/issues/r1696441166) * **query_report:** don't crash if `execution_time` isn't defined ([12140a9](12140a9)) * remove context from translatable strings in Workspace (backport [#27249](#27249)) ([#27255](#27255)) ([b28df79](b28df79)) * resolve merge conflicts ([ee28961](ee28961)) * **script_helpers:** prevent TypeError when cur_frm is null ([49e7247](49e7247)) * set fields value if this.frm exist ([c42e539](c42e539)) * translate header inner text if it is a simple text ([257be8e](257be8e)) * translation in form.js (backport [#26907](#26907)) ([#27250](#27250)) ([ddd47fe](ddd47fe)) * translation of dashboard chart and number card label (backport [#25793](#25793)) ([#27305](#27305)) ([e2d9008](e2d9008)) * **XLSX:** remove unsupported characters from sheet title ([a36dce8](a36dce8)) ### Features * Allow Setting email, share and print perms via User Type ([efc2df1](efc2df1))
|
🎉 This issue has been resolved in version 15.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop new users from creating workspace by moving the buttons to the bottom