Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout improvements #386

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Layout improvements #386

merged 12 commits into from
Jan 10, 2024

Conversation

zonia3000
Copy link
Collaborator

@zonia3000 zonia3000 commented Jan 9, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Closes #238
Closes #383
Closes #384
Closes #385
Closes #302
Closes #381

Copy link

github-actions bot commented Jan 9, 2024

Coverage report
 ---------------------------------------|---------|----------|---------|---------|-------------------
File                                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
---------------------------------------|---------|----------|---------|---------|-------------------
All files                              |   48.24 |    31.86 |   50.45 |   51.96 |                   
 src                                   |       0 |        0 |       0 |       0 |                   
  hooks.server.js                      |       0 |        0 |       0 |       0 | 5-61              
 src/lib/common                        |    74.1 |    69.52 |      90 |    75.2 |                   
  component_utilities.js               |   81.01 |    75.36 |   88.23 |   80.88 | ...33-144,156,196 
  errors.js                            |   59.57 |    58.06 |   88.88 |   60.86 | ...,96,99,138,160 
  jschema_validation.js                |   84.61 |       60 |     100 |     100 | 25-33             
 src/lib/components/admin              |   78.97 |    64.53 |   95.31 |   87.65 |                   
  UserEditor.svelte                    |   78.75 |    62.87 |   95.16 |    87.5 | ...1286,1332-1333 
  user_utilities.js                    |     100 |      100 |     100 |     100 |                   
 src/lib/components/common             |   81.28 |    58.82 |   87.78 |   85.71 |                   
  BooleanIcon.svelte                   |   68.11 |     37.5 |    90.9 |   71.42 | ...,28-33,109-115 
  ConfirmActionButton.svelte           |   88.05 |    54.13 |   97.67 |   94.49 | ...39,329-335,341 
  Modal.svelte                         |    82.2 |    66.66 |    82.6 |   86.88 | ...77,281,285,494 
  StandardDismissableAlert.svelte      |   65.06 |    52.38 |      75 |   67.12 | ...22,139-140,158 
  StandardErrorAlert.svelte            |   93.33 |       50 |     100 |    90.9 | 13                
 src/lib/components/common/filterable  |   72.13 |       30 |      75 |      80 |                   
  Th.svelte                            |   72.13 |       30 |      75 |      80 | ...53,75-77,86-89 
 src/lib/components/common/jschema     |    6.73 |     7.67 |    7.55 |     7.3 |                   
  ArrayProperty.svelte                 |       0 |        0 |       0 |       0 | 6-556             
  BooleanProperty.svelte               |       0 |        0 |       0 |       0 | 5-265             
  JSchema.svelte                       |       0 |        0 |       0 |       0 | 34-578            
  NumberProperty.svelte                |       0 |        0 |       0 |       0 | 5-238             
  ObjectProperty.svelte                |       0 |        0 |       0 |       0 | 6-840             
  PropertiesBlock.svelte               |       0 |        0 |       0 |       0 | 6-348             
  PropertyDescription.svelte           |       0 |        0 |       0 |       0 | 4-167             
  PropertyDiscriminator.svelte         |       0 |        0 |       0 |       0 | 9-576             
  SchemaInput.svelte                   |       0 |        0 |     100 |       0 | 4-58              
  StringProperty.svelte                |       0 |        0 |       0 |       0 | 5-235             
  schema_management.js                 |   86.97 |    71.42 |   86.84 |   86.41 | ...77,294-304,364 
 src/lib/components/jobs               |   71.95 |    48.42 |   74.65 |   74.52 |                   
  JobInfoModal.svelte                  |   60.52 |    16.14 |   70.31 |   64.54 | ...66-671,726-736 
  JobLogsModal.svelte                  |   68.31 |       25 |   82.14 |   74.15 | ...77-178,189-196 
  JobStatusIcon.svelte                 |       0 |        0 |     100 |       0 | 3-17              
  JobsList.svelte                      |   75.36 |    55.84 |   73.95 |   77.48 | ...3096,3120-3123 
  StatusBadge.svelte                   |    90.9 |       50 |     100 |   91.89 | 12,61,65          
 src/lib/components/projects           |   70.32 |    48.38 |   80.37 |   76.46 |                   
  CreateUpdateDatasetModal.svelte      |   65.44 |    52.83 |   75.42 |    72.8 | ...1943,1985-1986 
  CreateWorkflowModal.svelte           |   75.45 |    63.71 |   90.62 |   80.64 | ...88-589,618,667 
  ProjectDatasetsList.svelte           |   85.47 |    43.61 |   88.67 |   91.46 | ...47,627-629,654 
  ProjectInfoModal.svelte              |   49.63 |     31.5 |   69.49 |   52.98 | ...72,691-693,734 
  ProjectsList.svelte                  |   74.64 |       50 |   83.95 |   80.47 | ...59,879-881,907 
  WorkflowsList.svelte                 |   84.02 |       50 |   82.97 |   89.42 | ...85-596,629-630 
 src/lib/components/tasks              |   56.56 |    43.46 |   61.65 |   60.74 |                   
  AddSingleTask.svelte                 |   56.18 |    56.96 |   83.63 |   61.72 | ...1757-1758,1772 
  TaskCollection.svelte                |   62.77 |    41.19 |      60 |   66.23 | ...1968,1975-1976 
  TaskCollectionLogsModal.svelte       |   61.11 |    22.72 |      75 |   60.49 | ...37-148,167-179 
  TaskEditModal.svelte                 |   48.24 |     37.4 |   40.86 |   51.54 | ...1163-1256,1267 
  TaskInfoModal.svelte                 |   54.85 |    37.03 |   69.51 |   60.28 | ...40,864,883-892 
 src/lib/components/workflow           |   20.69 |    14.35 |   21.57 |   20.85 |                   
  ArgumentForm.svelte                  |       0 |        0 |       0 |       0 | 15-128            
  ArgumentsSchema.svelte               |       0 |        0 |       0 |       0 | 8-350             
  MetaPropertiesForm.svelte            |       0 |        0 |       0 |       0 | 16-141            
  TasksOrderModal.svelte               |       0 |        0 |       0 |       0 | 5-130             
  VersionUpdate.svelte                 |   14.69 |     11.7 |    2.22 |   13.66 | ...5,279,283-1407 
  WorkflowTaskSelection.svelte         |   52.92 |    33.33 |   66.66 |    56.6 | ...16,668-695,713 
  task_form_utils.js                   |       0 |        0 |       0 |       0 | 19-122            
  version-checker.js                   |    90.9 |    88.88 |     100 |    90.9 | 22                
 src/lib/components/workflow/common    |       0 |        0 |       0 |       0 |                   
  FormBaseEntry.svelte                 |       0 |        0 |       0 |       0 | 7-790             
  FormBuilder.svelte                   |       0 |        0 |       0 |       0 | 5-129             
  FormStructure.svelte                 |       0 |        0 |       0 |       0 | 9-1152            
  NewEntryProperty.svelte              |       0 |        0 |       0 |       0 | 3-732             
 src/lib/server/api                    |       0 |        0 |       0 |       0 |                   
  admin_api.js                         |       0 |        0 |       0 |       0 | 10-40             
 src/lib/server/api/v1                 |       0 |        0 |       0 |       0 |                   
  auth_api.js                          |       0 |        0 |       0 |       0 | 11-99             
  dataset_api.js                       |       0 |        0 |       0 |       0 | 10-19             
  project_api.js                       |       0 |        0 |       0 |       0 | 12-179            
  task_api.js                          |       0 |        0 |       0 |       0 | 10-22             
  workflow_api.js                      |       0 |        0 |       0 |       0 | 10-68             
 src/lib/stores                        |      75 |      100 |     100 |      75 |                   
  authStores.js                        |       0 |      100 |     100 |       0 | 3                 
  errorStores.js                       |     100 |      100 |     100 |     100 |                   
  projectStores.js                     |     100 |      100 |     100 |     100 |                   
  serverStores.js                      |       0 |      100 |     100 |       0 | 3                 
  taskStores.js                        |     100 |      100 |     100 |     100 |                   
 src/routes                            |   76.45 |    55.29 |   61.11 |   80.56 |                   
  +layout.server.js                    |       0 |        0 |       0 |       0 | 6-38              
  +layout.svelte                       |      90 |    82.75 |     100 |   91.04 | 5,128-132         
  +page.svelte                         |   82.75 |       46 |   95.65 |    90.9 | ...,49,52,353-366 
  proxy.js                             |       0 |        0 |       0 |       0 | 7-92              
 src/routes/admin                      |   62.29 |       50 |   85.71 |   61.11 |                   
  +page.svelte                         |   62.29 |       50 |   85.71 |   61.11 | 1-9,45-60         
 src/routes/admin/jobs                 |   50.55 |     43.1 |   54.76 |   56.27 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 6-11              
  +page.svelte                         |   50.66 |     43.1 |    55.2 |   56.41 | ...1854,1878-1884 
 src/routes/admin/users                |   58.85 |    14.09 |   57.14 |   64.48 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-10              
  +page.svelte                         |   59.18 |    14.09 |   58.33 |   64.89 | ...34,666,700-707 
 src/routes/admin/users/[userId]       |   49.14 |       35 |   83.33 |    51.3 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-10              
  +page.svelte                         |    49.5 |       35 |    90.9 |   51.71 | ...,47-57,209-355 
 src/routes/admin/users/[userId]/edit  |   82.92 |       50 |    92.3 |   87.61 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-10              
  +page.svelte                         |      85 |       50 |     100 |      90 | 6-34              
 src/routes/admin/users/register       |   42.55 |       40 |   63.15 |   47.82 |                   
  +page.svelte                         |   42.55 |       40 |   63.15 |   47.82 | ...00-201,258,272 
 src/routes/api/[...path]              |       0 |      100 |     100 |       0 |                   
  +server.js                           |       0 |      100 |     100 |       0 | 6-9               
 src/routes/api/admin/[...path]        |       0 |      100 |     100 |       0 |                   
  +server.js                           |       0 |      100 |     100 |       0 | 6-9               
 src/routes/api/auth/[...path]         |       0 |      100 |     100 |       0 |                   
  +server.js                           |       0 |      100 |     100 |       0 | 6-9               
 src/routes/auth/login                 |   59.03 |       45 |       0 |   58.06 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-22              
  +page.svelte                         |   69.01 |       50 |     100 |      72 | 12,24-32,99-108   
  cookie.js                            |       0 |        0 |       0 |       0 | 18-29             
 src/routes/auth/login/oauth2          |       0 |        0 |       0 |       0 |                   
  +layout.server.js                    |       0 |        0 |       0 |       0 | 7-45              
  +page.svelte                         |       0 |      100 |     100 |       0 | 1                 
 src/routes/auth/logout                |   63.63 |       50 |      80 |   63.15 |                   
  +page.svelte                         |   63.63 |       50 |      80 |   63.15 | 6-16,24           
 src/routes/auth/token/logout          |       0 |        0 |       0 |       0 |                   
  +server.js                           |       0 |        0 |       0 |       0 | 12-25             
 src/routes/jobs                       |   33.33 |       25 |   35.29 |    37.5 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 6-25              
  +page.svelte                         |      50 |       25 |      60 |   52.17 | 14-18,31,42-51,67 
 src/routes/profile                    |   78.11 |    47.77 |   88.63 |   86.24 |                   
  +page.svelte                         |   78.11 |    47.77 |   88.63 |   86.24 | ...13-814,823,846 
 src/routes/projects                   |   60.52 |       25 |   61.53 |      60 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 4-18              
  +page.svelte                         |   71.87 |       25 |      80 |   72.41 | 7,34-36,51-54     
 src/routes/projects/[projectId]       |   74.16 |    37.27 |   82.14 |   78.27 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 4-12              
  +page.svelte                         |   75.21 |    37.27 |   83.63 |   79.54 | ...19-551,557-558 
 ...s/[projectId]/datasets/[datasetId] |       0 |        0 |       0 |       0 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 4-10              
  +page.svelte                         |       0 |        0 |     100 |       0 | 6-179             
 ...[projectId]/workflows/[workflowId] |    37.3 |     24.7 |   46.27 |   41.08 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-15              
  +page.svelte                         |   37.35 |     24.7 |   46.36 |   41.15 | ...5526,5537-5538 
 ...ectId]/workflows/[workflowId]/jobs |   44.17 |    21.21 |   44.44 |   48.08 |                   
  +page.server.js                      |       0 |        0 |       0 |       0 | 6-35              
  +page.svelte                         |   47.89 |    22.58 |      60 |   51.76 | ...38-243,260-272 
 ...orkflows/experimental/[workflowId] |       0 |        0 |       0 |       0 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 5-15              
  +page.svelte                         |       0 |        0 |       0 |       0 | 22-1135           
 src/routes/sandbox                    |       0 |        0 |       0 |       0 |                   
  +layout.js                           |       0 |        0 |       0 |       0 | 4-5               
 src/routes/sandbox/jsonschema         |       0 |      100 |     100 |       0 |                   
  +page.svelte                         |       0 |      100 |     100 |       0 | 5-15              
 src/routes/tasks                      |   70.49 |     36.3 |   57.47 |   71.93 |                   
  +page.server.js                      |       0 |      100 |       0 |       0 | 6-10              
  +page.svelte                         |   70.76 |     36.3 |   58.13 |   72.25 | ...1121,1137-1143 
---------------------------------------|---------|----------|---------|---------|-------------------
 

@zonia3000 zonia3000 merged commit 68bca44 into main Jan 10, 2024
12 checks passed
@zonia3000 zonia3000 deleted the layout-improvements branch January 10, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant