-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added modal for creating/updating datasets #310
Conversation
@tcompa Let me know if the modals work as expected, then we should define better how the "open" feature should be implemented. At the moment the page shown with the open button has not been modified. |
Brief recap of the points discussed live:
|
Now working as expected
Now working as expected
Now working as expected
Now working as expected, see red message in the bottom:
Now working as expected, see screenshot above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with latest version, and the main feature is as expected. If there remain glitches or weird edge cases, we can address them elsewhere.
I'd say this is good for merging, unless @zonia3000 has something more to add/review.
Happy to test later today. But that can be after the merge, I'd open new issues if they arise :) |
I'd say you can wait and directly test the upcoming v0.6 (ref #308), to avoid having too many back-and-forth rounds. |
For me it can be merged. |
Checklist before merging
CHANGELOG.md
Closes #299