Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some buttons unclickable until server feedback #387

Closed
5 tasks done
jluethi opened this issue Jan 9, 2024 · 2 comments · Fixed by #389
Closed
5 tasks done

Make some buttons unclickable until server feedback #387

jluethi opened this issue Jan 9, 2024 · 2 comments · Fixed by #389

Comments

@jluethi
Copy link
Collaborator

jluethi commented Jan 9, 2024

Similar to how we made the task collection button not clickable twice while waiting on server feedback, we should do this for other buttons as well.

This came up because it was possible (due to some performance issues in 1.4.1) for users to submit the same job multiple times by clicking the Confirm button in "Run workflow" multiple times. We should think about whether other buttons also could have this issue where it would matter.
I don't care too much about behaviors that would be unproblematic. e.g. download job logs: If a user clicks that 5x, they may get the job logs 5 times. But nothing breaks.

Buttons to deactivate after click until server response:

  • Confirm job submission
  • Task updating (on the workflow page)
  • Maybe project creation?
  • Maybe dataset creation?
  • Maybe workflow creation/import?

Not 100% sure whether it makes sense for the new creation buttons / how they'd handle multiple clicks if the server response was very slow

@zonia3000
Copy link
Collaborator

Regarding dataset and workflow creation the buttons are already disabled and showing a spinner when the request is in progress.

Following screenshot were taken with browser having network throttled (otherwise it is difficult to see the result).

image

image

image

image

image

image

image

image

@jluethi
Copy link
Collaborator Author

jluethi commented Jan 12, 2024

That looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants